Skip to content

fix: support symlinked skill discovery and robust install agent counting#325

Merged
subsy merged 3 commits intomainfrom
fix/checkpoint-uncommitted-2026-02-20
Feb 20, 2026
Merged

fix: support symlinked skill discovery and robust install agent counting#325
subsy merged 3 commits intomainfrom
fix/checkpoint-uncommitted-2026-02-20

Conversation

@subsy
Copy link
Copy Markdown
Owner

@subsy subsy commented Feb 20, 2026 •
edited by coderabbitai bot
Loading

Summary

  • allow info skill discovery to scan symlinked skill directories (not only physical directories) when reading custom skills_dir
  • make skills install summary parsing resilient when "Detected X agents" is missing by falling back to parsed "Installing to:" entries
  • filter empty parsed agent names to avoid incorrect counts and noisy output

Tests Added

  • tests/commands/info.test.ts: verifies custom skills are discovered from a symlinked skill directory
  • src/commands/skills.test.ts: verifies parser fallback to parsed install target list when detected count is absent
  • src/commands/skills-install.test.ts: verifies CLI output summary for fallback counting path

Files Changed

  • src/commands/info.ts
  • src/commands/skills.ts
  • src/commands/skills.test.ts
  • src/commands/skills-install.test.ts
  • tests/commands/info.test.ts

Notes

  • removed accidental a.out artifact from this PR in follow-up commit 8c07e32

Summary by CodeRabbit

  • New Features

    • Skill discovery now recognises symbolic-linked custom skill directories.

  • Bug Fixes

    • Improved handling when installation output omits detected agent count; falls back to parsed agent list.
    • Agent list parsing now ignores empty entries.

  • Tests

    • Added tests for symlinked skill discovery and fallback agent-count parsing.

  • Documentation

    • Condensed and removed longstanding agent quick-reference content, replaced with a compact reference link.

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 20, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
ralph-tui Ignored Ignored Preview Feb 20, 2026 4:04pm

Request Review

@subsy subsy changed the title chore: checkpoint uncommitted changes before task usage indicators fix: support symlinked skills dirs and robust install agent counting Feb 20, 2026
@subsy subsy changed the title fix: support symlinked skills dirs and robust install agent counting fix: support symlinked skill discovery and robust install agent counting Feb 20, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 20, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

Walkthrough

Adds symlink support to skill discovery and improves parsing of skills installation output by filtering agent entries and falling back to parsed agent list when the detected agent count is missing. Tests added to cover both behaviours.

Changes

Cohort / File(s) Summary
Skill discovery (symlink support)
src/commands/info.ts, tests/commands/info.test.ts		 listSkillsInDir now treats symbolic links like directories when detecting skills; test suite adds a case creating a symlinked skill dir and asserting discovery.
Skills installation output parsing & tests
src/commands/skills.ts, src/commands/skills-install.test.ts, src/commands/skills.test.ts		 parseAddSkillOutput now filters out empty agent entries, captures a detected agent count if present, and falls back to the parsed agents length when the detected count is omitted. Tests verify fallback behaviour and summary formatting.
Documentation cleanup
AGENTS.md, CLAUDE.md		 Large removal/replacement of agent guidance content: AGENTS.md had a block removed; CLAUDE.md replaced with a single reference line to AGENTS.md.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately captures the two main changes: symlinked skill discovery support and robust install agent counting with fallback logic.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/checkpoint-uncommitted-2026-02-20

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@subsy subsy merged commit b9714f3 into main Feb 20, 2026
7 checks passed
@subsy subsy deleted the fix/checkpoint-uncommitted-2026-02-20 branch February 20, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@subsy