macOS: Fix the Homebrew Based Build.#4734
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the macOS Homebrew-based build setup by aligning the pinned libmtp dependency version with Homebrew’s current package version and correcting a build-script pathing issue to use the computed build output directory.
Changes:
- Bump the pinned
libmtpsource dependency version fromv1.1.22tov1.1.23. - Fix the Homebrew local build script to
cdinto the computed$BUILDDIRbefore signing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
scripts/get-dep-lib.sh |
Updates the pinned libmtp version tag to v1.1.23. |
packaging/macosx/homebrew-local-build.sh |
Fixes the working directory used for codesign by switching to $BUILDDIR. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| cd $BUILDDIR | ||
| codesign --force --deep --sign - Subsurface.app | ||
|
|
||
| echo "Run Subsurface with 'open subsurface/build/Subsurface.app'" |
There was a problem hiding this comment.
cd $BUILDDIR is unquoted and unchecked. If the working directory path contains spaces (common on macOS), this will fail and the subsequent codesign will run in the wrong directory. Consider cd "$BUILDDIR" || croak "can't cd to $BUILDDIR" and also update the final open subsurface/build/Subsurface.app message to reflect the actual $BUILDDIR (since it can be $(pwd)/build/ when subsurface is a symlink).
|
Artifacts: |
|
Artifacts: |
|
Artifacts: |
|
Artifacts: |
Update the libmtp library version dependency to what is currently being installed by homebrew. In a way this is backwards, but since homebrew does not have a reasonable way to install non-latest versions this seems to be the path of least resistance to keep this working, as long as the version updates don't break anything else. Also fix a pathing issue in the homebrew build script. Signed-off-by: Michael Keller <github@ike.ch>
6d5f21a to
63a7dde
Compare
|
Artifacts: |
|
Artifacts: |
|
Artifacts: |
|
Artifacts: |
Describe the pull request:
Pull request long description:
Update the libmtp library version dependency to what is currently being
installed by homebrew. In a way this is backwards, but since homebrew
does not have a reasonable way to install non-latest versions this seems
to be the path of least resistance to keep this working, as long as the
version updates don't break anything else.
Changes made:
Related issues:
Additional information:
Documentation change:
Mentions: