Skip to content

Make profile size configurable#4733

Merged
atdotde merged 3 commits intosubsurface:masterfrom
atdotde:profileexportsize
Mar 2, 2026
Merged

Make profile size configurable#4733
atdotde merged 3 commits intosubsurface:masterfrom
atdotde:profileexportsize

Conversation

@atdotde
Copy link
Collaborator

@atdotde atdotde commented Feb 28, 2026

Describe the pull request:

  • Bug fix
  • Functional change
  • New feature
  • Code cleanup
  • Build system change
  • Documentation change
  • Language translation

Pull request long description:

Subsurface has been used to create profile images for publishing. But these users have requested to make the
aspect ratio and resolution configurable. This PR adds corresponding UI elements to the export dialog.

It also silences an annoying clang compiler warning about the presence of linker options in compiler runs.

Changes made:

Related issues:

Additional information:

Documentation change:

Mentions:

@atdotde
Silence compiler warnings about unused linker parameters
6fcd069 
Signed-off-by: Robert C. Helling <helling@atdotde.de>
@atdotde
Let the user decide about the size of exported profile
60d629b 
Add UI elements in the export dialog to let the user
pick width and height of the exported profile. In
particular, they can thus now choose an aspect ratio
and a resolution.

Signed-off-by: Robert C. Helling <helling@atdotde.de>
@atdotde atdotde added the export label Feb 28, 2026
@github-actions
Copy link

github-actions bot commented Feb 28, 2026

Artifacts:
Subsurface-Linux-AppImage-6.0.5553-patch.2.pull-request.profileexportsize
WARNING: Use at your own risk.

@github-actions
Copy link

github-actions bot commented Feb 28, 2026

Artifacts:
Subsurface-MacOS-arm64-qt-6.8.3-6.0.5553-patch.2.pull-request.profileexportsize
Subsurface-MacOS-x86_64-qt-5-6.0.5553-patch.2.pull-request.profileexportsize
Subsurface-MacOS-x86_64-qt-6.8.3-6.0.5553-patch.2.pull-request.profileexportsize
WARNING: Use at your own risk.

@github-actions
Copy link

github-actions bot commented Feb 28, 2026

Artifacts:
Subsurface-Android-6.0.5553-patch.2.pull-request.profileexportsize
WARNING: Use at your own risk.

@github-actions
Copy link

github-actions bot commented Feb 28, 2026

Artifacts:
Subsurface-Windows-6.0.5553-patch.2.pull-request.profileexportsize
WARNING: Use at your own risk.

@github-actions
Copy link

github-actions bot commented Feb 28, 2026

Artifacts:
Subsurface-Windows-MSVC-qt-6-6.0.5553-patch.2.pull-request.profileexportsize
WARNING: Use at your own risk.

mikeller
mikeller approved these changes Feb 28, 2026
View reviewed changes
Copy link
Member

@mikeller mikeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@atdotde
Update user manual with new profile export features.
f77139c 
English and German versions have been updated.

Signed-off-by: Robert C. Helling <helling@atdotde.de>
@github-actions
Copy link

github-actions bot commented Mar 1, 2026

Artifacts:
Subsurface-Documentation-6.0.5553-patch.3.pull-request.profileexportsize
WARNING: Use at your own risk.

@github-actions
Copy link

github-actions bot commented Mar 1, 2026

Artifacts:
Subsurface-Android-6.0.5553-patch.3.pull-request.profileexportsize
WARNING: Use at your own risk.

@github-actions
Copy link

github-actions bot commented Mar 1, 2026

Artifacts:
Subsurface-Linux-AppImage-6.0.5553-patch.3.pull-request.profileexportsize
WARNING: Use at your own risk.

@github-actions
Copy link

github-actions bot commented Mar 1, 2026

Artifacts:
Subsurface-MacOS-arm64-qt-6.8.3-6.0.5553-patch.3.pull-request.profileexportsize
Subsurface-MacOS-x86_64-qt-6.8.3-6.0.5553-patch.3.pull-request.profileexportsize
Subsurface-MacOS-x86_64-qt-5-6.0.5553-patch.3.pull-request.profileexportsize
WARNING: Use at your own risk.

@github-actions
Copy link

github-actions bot commented Mar 1, 2026

Artifacts:
Subsurface-Windows-MSVC-qt-6-6.0.5553-patch.3.pull-request.profileexportsize
WARNING: Use at your own risk.

@github-actions
Copy link

github-actions bot commented Mar 1, 2026

Artifacts:
Subsurface-Windows-6.0.5553-patch.3.pull-request.profileexportsize
WARNING: Use at your own risk.

@atdotde atdotde merged commit 087289a into subsurface:master Mar 2, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikeller mikeller mikeller approved these changes

Assignees

No one assigned

Labels

export

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@atdotde @mikeller