CICD: Fix the Fedora Build.#4732
Conversation
Add 'qt6-qtbase-private-devel' to the dependencies to be installed. Signed-off-by: Michael Keller <github@ike.ch>
Add '.vscode', remove '.gitignore'. Signed-off-by: Michael Keller <github@ike.ch>
|
Artifacts: |
There was a problem hiding this comment.
Pull request overview
This PR updates the Fedora Qt6 CI workflow to install an additional Qt package needed for the Fedora build, and adjusts gitignore entries to ignore VS Code settings while removing an unnecessary ignore rule for .gitignore.
Changes:
- Add
qt6-qtbase-private-develto Fedora CI dependencies. - Update
.gitignoreto ignore.vscodeand stop ignoring.gitignore.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.gitignore |
Ignore VS Code project settings; remove redundant .gitignore ignore entry. |
.github/workflows/linux-fedora-qt6.yml |
Install an additional Qt6 private-devel dependency to fix Fedora CI build. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| qt6-qttools-devel redhat-rpm-config \ | ||
| libxkbcommon-devel qt6-qt5compat-devel \ | ||
| qt6-qtbase-private-devel \ | ||
| bluez-libs-devel libgit2-devel libzip-devel libmtp-devel LibRaw-devel \ |
There was a problem hiding this comment.
bluez-libs-devel is listed twice in the same dnf install command (first on line 29, again on line 37). This is redundant and makes the dependency list harder to maintain; please remove the duplicate occurrence.
| bluez-libs-devel libgit2-devel libzip-devel libmtp-devel LibRaw-devel \ | |
| libgit2-devel libzip-devel libmtp-devel LibRaw-devel \ |
|
Artifacts: |
|
Artifacts: |
|
Artifacts: |
|
Merging to unblock CICD releases. |
Describe the pull request:
Pull request long description:
Add 'qt6-qtbase-private-devel' to the dependencies to be installed.
Changes made:
Related issues:
Additional information:
Documentation change:
Mentions: