"bundleExternal: false" cause empty file in windows #740
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use browserify in windows, and run the code like following.
But browserfiy create an empty content js file.
After a long time debuging, I found the following code in 'Browserify.prototype._resolve'
I think it is proposed to recorgnize the the path for external bundle when the path is like "lodash" or "jquery/ui".
But in windows, the result of resolve('./app.js') is 'd:\xxx\app.js'. The resolve method also recorgize it as an external module, and ignore it!