CSL Preferences [WIP]#6
Closed
subhramit wants to merge 4 commits into
Closed
Conversation
Siedlerchr
reviewed
Jul 12, 2024
Siedlerchr
reviewed
Jul 12, 2024
Siedlerchr
reviewed
Jul 12, 2024
calixtus
reviewed
Jul 12, 2024
Owner
Author
|
Applied review changes |
Siedlerchr
reviewed
Jul 13, 2024
| /** | ||
| * @param style This can be either a String (for CSL) or OOBibStyle (for JStyle) | ||
| */ | ||
| public class StyleIdentifier { |
Collaborator
There was a problem hiding this comment.
You now run into the architecture issues I already talked about in the beginning.
Make this an interface.
Let both CSLStyle and OOStyle implement the interface
In the StyleSelectionViewMOdel you then store he concrete style object
https://docs.oracle.com/en/java/javase/17/language/pattern-matching-instanceof-operator.html
As an example you can take a look at the PreviewLayout interface and it's subclasses, e.g. CitationStylePreviewLayout
The latter one also has a path method
I think this makes it a bit more cleaner and you don't have to do a cast to object
This was referenced Jul 15, 2024
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Halted due to architecture changes (#7 ).
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)