Skip to content

Handle Reference Numbers for independently cited entries#12

Closed
subhramit wants to merge 21 commits into
mainfrom
sync-numbers
Closed

Handle Reference Numbers for independently cited entries#12
subhramit wants to merge 21 commits into
mainfrom
sync-numbers

Conversation

@subhramit

@subhramit subhramit commented Aug 2, 2024

Copy link
Copy Markdown
Owner

Preliminary implementation

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

citationKeyToNumber.put(citationKey, citationNumber);
highestCitationNumber = Math.max(highestCitationNumber, citationNumber);
} catch (NumberFormatException e) {
// Ignore if we can't parse the number

@antalk2 antalk2 Aug 3, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On restarting JabRef, the numbering starts from 1 again for the same document.

Does logging these exceptions show a possible reason?

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tried, the exception is not triggered..

@subhramit

subhramit commented Aug 9, 2024

Copy link
Copy Markdown
Owner Author

Closing,
Superseded by JabRef#11577

@subhramit subhramit closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants