Skip to content

chore: Fix spelling errors and modernize pointer initialization#2631

Merged
bigfooted merged 2 commits intosu2code:developfrom
shbhmexe:chore/code-quality-improvements
Nov 27, 2025
Merged

chore: Fix spelling errors and modernize pointer initialization#2631
bigfooted merged 2 commits intosu2code:developfrom
shbhmexe:chore/code-quality-improvements

Conversation

@shbhmexe
Copy link

@shbhmexe shbhmexe commented Nov 27, 2025

Proposed Changes

This PR improves code quality through 4 targeted fixes across 2 files:

1. Spelling Corrections (3 fixes)

Common/src/CConfig.cpp:

  • Line 6169: Fixed double typo "Idenftification fo" → "Identification of"
  • Line 6170: Fixed spelling "seperate" → "separate"

SU2_CFD/include/solvers/CGradientSmoothingSolver.hpp:

  • Line 278: Fixed spelling "seperate" → "separate" in function documentation

2. Code Modernization (1 fix)

Common/src/CConfig.cpp:

  • Lines 9991-9992: Replace NULL with nullptr

Before:

double *l_min_red = NULL, *l_max_red = NULL, *l_tot_red = NULL, *l_avg_red = NULL;
int *n_calls_red = NULL;

After:

double *l_min_red = nullptr, *l_max_red = nullptr, *l_tot_red = nullptr, *l_avg_red = nullptr;
int *n_calls_red = nullptr;

Rationale: Modern C++ (C++11+) recommends nullptr over NULL for better type safety and to avoid ambiguity in function overload resolution.

Related Work

  • Resolves: N/A
  • Related Issues: None
  • Related PRs: None

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

Impact Summary

Category Impact
Functionality None (safe improvements only)
Performance No impact
Breaking Changes None
Type Safety Improved (nullptr is type-safe)
Code Quality Improved
C++ Standard Better C++11 compliance
Tests No changes needed
Compatibility 100% compatible

@shbhmexe
chore: Fix spelling errors and modernize pointer initialization
c27a6a3 
This PR improves code quality through two types of fixes:

Spelling Corrections (3 fixes):
- CConfig.cpp (L6169): "Idenftification fo" → "Identification of"
- CConfig.cpp (L6170): "seperate" → "separate"
- CGradientSmoothingSolver.hpp (L278): "seperate" → "separate"

Code Modernization (1 fix):
- CConfig.cpp (L9991-9992): Replace NULL with nullptr for C++11 compliance and better type safety

All changes are safe, non-breaking, and improve code quality.

Signed-off-by: shbhmexe <shubhushukla586@gmail.com>
@shbhmexe
Copy link
Author

shbhmexe commented Nov 27, 2025

/label changelog:fix

@bigfooted
Copy link
Contributor

bigfooted commented Nov 27, 2025

The merge should go into su2:develop, not su2:master. You can change this at the top of the page when you choose edit next to the title of the PR.

@bigfooted
Copy link
Contributor

bigfooted commented Nov 27, 2025

/label changelog:fix

on the right side of the page you see
Labels:
None yet
Choose the wheel for edit and choose :"Changelog:Chore"

@shbhmexe
Copy link
Author

shbhmexe commented Nov 27, 2025

/label changelog:fix

on the right side of the page you see Labels: None yet Choose the wheel for edit and choose :"Changelog:Chore"

I’m not able or allowed to add labels to this PR on my end. If possible, could you please add the appropriate labels? Thank you!

@bigfooted
Copy link
Contributor

bigfooted commented Nov 27, 2025

/label changelog:fix

on the right side of the page you see Labels: None yet Choose the wheel for edit and choose :"Changelog:Chore"

I’m not able or allowed to add labels to this PR on my end. If possible, could you please add the appropriate labels? Thank you!

OK, thanks, it's sometimes not clear what you can and cannot add as an external contributor. Can you edit the PR and point it to develop instead of master? Thanks!

@shbhmexe
Copy link
Author

shbhmexe commented Nov 27, 2025

/label changelog:fix

on the right side of the page you see Labels: None yet Choose the wheel for edit and choose :"Changelog:Chore"

I’m not able or allowed to add labels to this PR on my end. If possible, could you please add the appropriate labels? Thank you!

OK, thanks, it's sometimes not clear what you can and cannot add as an external contributor. Can you edit the PR and point it to develop instead of master? Thanks!

Yes i change pr , now it’s point to develop branch

@bigfooted bigfooted merged commit d542249 into su2code:develop Nov 27, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcarruscag pcarruscag pcarruscag approved these changes

Assignees

No one assigned

Labels

changelog:chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shbhmexe @bigfooted @pcarruscag