Using free stream tremperature for initialization of wall temperature for pure conjugate heat transfer problems#2281
Merged
Cristopher-Morales merged 2 commits intodevelopfrom May 14, 2024
Merged
Conversation
EvertBunschoten
approved these changes
May 14, 2024
Co-authored-by: Evert Bunschoten <38651601+EvertBunschoten@users.noreply.github.com>
Member
|
Why is this being accessed out of bounds? Instead of adding a potentially confusing default behavior we should not access a marker that doesnt exist. |
Contributor
|
In CNSSolver, we do in BC_Isothermal_Wall_Generic: And we do not check for cht_mode in IncNSSolver. I think this might be the root cause of entering this routine? |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
For pure conjugate heat transfer problems, the temperature at the walls is initialized using the free stream temperature. Using the Isothermal_Temperature[0] for pure CHT problems results in a segmentation fault error.
Related Work
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --allto format old commits.