Compressibility correction for SST model by sun5k · Pull Request #2271 · su2code/SU2

sun5k · 2024-04-23T05:39:58Z

Proposed Changes

Compressibility Correction(CC) for the k-w SST model.

Two kind of CC is implemented. Both CC were based on Wilcox's book(Turbulence Modeling for CFD 3rd) and the paper of Rumsey

The k-w SST model transport equation :

*The production term is according to version or options for SST model(SU2 ver 8.0.1 has 1994m or 2003m).

Wilcox

The H is the Heaviside function.
Sarkar
In the Sarkar's CC, the pressure dilatation() is considered. The k transport equation is :

Validation Case

Validation analysis is conducted for the hypersonic flat plate. Two different wall temperature(T_w/T_free = 1.090 and T_w/T_free = 2.725) results are presented and compared with simulation results of ANSYS Fluent.

The CC of Fluent and Wilcox is almost same, but they have different coefficients(Wilcox : / Fluent : ). So, The results show a similar behavior to the Fluent results.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

I am submitting my contribution to the develop branch.
My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
I have added a test case that demonstrates my contribution, if necessary.
I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

Added two compressibility correction( Wilcox and Zeman ) for the SST model.

bigfooted · 2024-04-23T17:34:33Z

That would be a nice addition! Can you also add a testcase (this flat plate testcase) for each of the cases, and add the cfg + regression tests to this repository? Maybe do the regression test on one of the coarsest meshes. Best would be to have set it up with a restart file that is completely converged.

bigfooted · 2024-04-29T07:18:17Z

Regrading the results: Why do we not see the dip in skin friction coefficient for low Reynolds like we see in the paper of Rumsey? The paper shows that predicting this dip is a feature of the model, and it makes it different from the van Driest theory.

regression Test

…on' into feature_Compressibility_Correction

Regression

t

Regression

remove hybrid/ add parallel

Wilcox_Regression

Re

Re2

Regression test for Wilcox and Sarkar .

Sarkar

Re

Regression Test

sun5k · 2024-05-02T08:57:53Z

That would be a nice addition! Can you also add a testcase (this flat plate testcase) for each of the cases, and add the cfg + regression tests to this repository? Maybe do the regression test on one of the coarsest meshes. Best would be to have set it up with a restart file that is completely converged.

Hi @bigfooted.

I made regression test on "parallel_regression.py". Should I make extra regression test on "hybrid_regression.py" and "serial_regression.py"?

sun5k · 2024-05-02T08:59:13Z

Regrading the results: Why do we not see the dip in skin friction coefficient for low Reynolds like we see in the paper of Rumsey? The paper shows that predicting this dip is a feature of the model, and it makes it different from the van Driest theory.

I thought it depended on the grid resolution. The case of fine resolution grid(545 x 385), we can see "dip" in SU2 result(but relatively small).

From the "Coarse-Zoom" plot, The "dip" in coarse mesh(138 x 97) also appears in SU2, but it is really weak.

Common/include/option_structure.hpp

SU2_CFD/include/numerics/turbulent/turb_sources.hpp

bigfooted · 2024-05-03T22:20:47Z

I copy the comment in the review here as well:
Can you check the equation for the pressure dilatation that you give above? Should I compare it to eq (39) of the paper? The equation (39) in the paper is $(-a_2 P M_t^2) +(a_3 \rho \epsilon M_t^2)$ which is different from what you write above and what is in the code. I guess you use the relationship $\epsilon=\beta^{\star} \omega k$, so the above becomes:
$(-a_2 P M_t^2) +(a_3 \beta^{\star} \rho \omega k M_t^2)$

You have in the code $(-a_2 P M_t) + (a_3 \beta^{\star} \rho \omega) + k M_t^2$

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Fix

Sarkar Regression

bigfooted · 2024-05-20T21:08:58Z

Can you add the updated results here? Did the results improve?

sun5k · 2024-05-22T02:06:37Z

Can you add the updated results here? Did the results improve?

Hi @bigfooted , I'm sorry to forgot shearing the updated result.

Here is the result fixed for the correct source term. The Cf is slightly shifted up.

This is a comparison of the previous and the fixed result.

bigfooted · 2024-06-12T08:13:38Z

@pcarruscag @sun5k Anything else necessary for this PR?

SU2_CFD/include/numerics/turbulent/turb_sources.hpp

TestCases/rans/flatplate/turb_SST_flatplate_compressibility_Sarkar.cfg

TestCases/rans/flatplate/turb_SST_flatplate_compressibility_Wilcox.cfg

Common/include/option_structure.hpp

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Break SU2 code, if either options is selected.

sun5k and others added 2 commits April 23, 2024 13:08

Compressibility Correction for SST model

aefc894

Added two compressibility correction( Wilcox and Zeman ) for the SST model.

Merge branch 'develop' into feature_Compressibility_Correction

67a16ec

bigfooted added the changelog:feature label Apr 23, 2024

Merge branch 'develop' into feature_Compressibility_Correction

b01341f

sun5k added 13 commits April 30, 2024 20:32

Wilcox regression

20e8ec1

regression Test

Merge remote-tracking branch 'origin/feature_Compressibility_Correcti…

d9f9a36

…on' into feature_Compressibility_Correction

Wilcox Regression

d7c5b14

Regression

test

aed13d4

t

Regression_Test

c358d0b

Regression

Regression_Test

11de147

remove hybrid/ add parallel

Regression_2

5b68ade

Wilcox_Regression

Reeeeeee

cdf5231

Re

Reee

d9efed5

Re2

Regression

39de5be

Regression test for Wilcox and Sarkar .

Regression

6581d96

Sarkar

Re

f315436

Re

Regression for Willcox and Sarkar

5594928

Regression Test

pcarruscag reviewed May 3, 2024

View reviewed changes

bigfooted reviewed May 3, 2024

View reviewed changes

SU2_CFD/include/numerics/turbulent/turb_sources.hpp Outdated Show resolved Hide resolved

sun5k and others added 6 commits May 5, 2024 18:26

Update Common/include/option_structure.hpp

3c0b73f

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/include/numerics/turbulent/turb_sources.hpp

3abd350

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/include/numerics/turbulent/turb_sources.hpp

6259103

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Fix Sarkar's pressure dilatation term

4a1280e

Fix

Regression

57d3699

Sarkar Regression

Merge branch 'develop' into feature_Compressibility_Correction

0075485

Merge branch 'develop' into feature_Compressibility_Correction

0e79209

Merge branch 'develop' into feature_Compressibility_Correction

da144af

pcarruscag reviewed Jun 12, 2024

View reviewed changes

sun5k and others added 8 commits June 13, 2024 10:36

Update SU2_CFD/include/numerics/turbulent/turb_sources.hpp

c96e235

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/include/numerics/turbulent/turb_sources.hpp

6c12bf8

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/include/numerics/turbulent/turb_sources.hpp

49e5eaa

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/include/numerics/turbulent/turb_sources.hpp

aa64487

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Break Compressibility Correction Option and Incompressible RANS

4aacfb9

Break SU2 code, if either options is selected.

Merge branch 'develop' into feature_Compressibility_Correction

ed632bc

Merge branch 'develop' into feature_Compressibility_Correction

3f9665b

Merge branch 'develop' into feature_Compressibility_Correction

c85ee1a

pcarruscag approved these changes Jul 21, 2024

View reviewed changes

pcarruscag merged commit 1044ccc into su2code:develop Jul 21, 2024

Conversation

sun5k commented Apr 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Validation Case

PR Checklist

Uh oh!

bigfooted commented Apr 23, 2024

Uh oh!

bigfooted commented Apr 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sun5k commented May 2, 2024

Uh oh!

sun5k commented May 2, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bigfooted commented May 3, 2024

Uh oh!

bigfooted commented May 20, 2024

Uh oh!

sun5k commented May 22, 2024

Uh oh!

bigfooted commented Jun 12, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sun5k commented Apr 23, 2024 •

edited

Loading

bigfooted commented Apr 29, 2024 •

edited

Loading