Skip to content

Fix cpu arch returned value in TestCase.py#2163

Merged
pcarruscag merged 4 commits intosu2code:developfrom
amitrdubey:fix_testcase_platform_check
Nov 17, 2023
Merged

Fix cpu arch returned value in TestCase.py#2163
pcarruscag merged 4 commits intosu2code:developfrom
amitrdubey:fix_testcase_platform_check

Conversation

@amitrdubey
Copy link
Contributor

Modify TestCase.py related to #2159.

Proposed Changes

Replaced platform.processor() with platform.machine() for better cross-platform support. Add amd64 and arm64 as additional supported cpu arch.

Related Work

Issue #2159

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

Modify TestCase.py related to su2code#2159.
@amitrdubey
Copy link
Contributor Author

Is there a way to resolve the failing test case. I can't see the proposed changes affecting that particular test case but can look into it if needed.

@pcarruscag pcarruscag merged commit a0cab87 into su2code:develop Nov 17, 2023
@jblueh
Copy link
Contributor

jblueh commented Nov 17, 2023

@TripleRider This has been an issue before, see #1984. I have also encountered this recently and decided to relax the tolerances further. The fix is pending in #2167.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants