Fix cpu arch returned value in TestCase.py#2163
Merged
pcarruscag merged 4 commits intosu2code:developfrom Nov 17, 2023
Merged
Conversation
Modify TestCase.py related to su2code#2159.
pcarruscag
approved these changes
Nov 9, 2023
Contributor
Author
|
Is there a way to resolve the failing test case. I can't see the proposed changes affecting that particular test case but can look into it if needed. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify TestCase.py related to #2159.
Proposed Changes
Replaced
platform.processor()withplatform.machine()for better cross-platform support. Addamd64andarm64as additional supported cpu arch.Related Work
Issue #2159
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --allto format old commits.