Make SST-1994m consistent with literature and use 2003m by default#2062
Merged
pcarruscag merged 14 commits intodevelopfrom Jul 3, 2023
Merged
Make SST-1994m consistent with literature and use 2003m by default#2062pcarruscag merged 14 commits intodevelopfrom
pcarruscag merged 14 commits intodevelopfrom
Conversation
pcarruscag
commented
Jul 1, 2023
bigfooted
approved these changes
Jul 3, 2023
Contributor
bigfooted
left a comment
There was a problem hiding this comment.
Great work, looks like we are following the nasa website description of the model now, and the residuals did not change by a lot so that's comforting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Remove divergence terms from the source term, use 2003m by default.
Related Work
Closes #1551
PR Checklist