BC inlet for SA solver based on local conditions at the Inlet#1953
Merged
Cristopher-Morales merged 12 commits intodevelopfrom Mar 10, 2023
Merged
BC inlet for SA solver based on local conditions at the Inlet#1953Cristopher-Morales merged 12 commits intodevelopfrom
Cristopher-Morales merged 12 commits intodevelopfrom
Conversation
pcarruscag
approved these changes
Mar 9, 2023
Member
pcarruscag
left a comment
There was a problem hiding this comment.
Check if you need to update the config template or any doc on the website.
It would also be good to modify an existing test case to exercise this feature.
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Contributor
Author
Thank you so much for your comment. Yes, I will update the website with this additional feature. I will modify one of the existing test cases in this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Give a brief overview of your contribution here in a few sentences.
Following to what was done in the pull request #1796 , we aim with this pull request to use the known fluid properties at the inlets in order to set the BC for the SA model. Also, we extent the use of the turbulent marker options for this case as It was done in the previous pull request for SST #1843.
I can add a test case if it is needed.
Related Work
related to pull request #1796 , #1843
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.