Access solution and primitives via python wrapper#1938
Merged
Conversation
Contributor
|
Oh, that's great! I like this way to get the solver index. This would also clean up the flamelet PR, that has a hacky pywrapper implementation for creating an initial solution for the flamelet solver. |
bigfooted
reviewed
Feb 26, 2023
bigfooted
approved these changes
Feb 28, 2023
Contributor
bigfooted
left a comment
There was a problem hiding this comment.
LGTM, if no more changes are required for this PR, let's merge it.
Contributor
|
maybe @patelha57 @aa-g have additional comments? Else let's merge, LGTM. |
Member
Author
|
I talked with @Nicola-Fonzi and I'll try to use the same "matrix view" strategy for data at markers. But if the current solution unblocks the flamelet work go ahead and merge this. |
Contributor
|
Ok, thanks. I will merge this now, then clean up the flamelet branch, so it will be ready for review next week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
@patelha57 @aa-g @Nicola-Fonzi @bigfooted
I'm proposing this as the way to interact with volume fields via the python wrapper.
We create a matrix view (does not copy data) into the coordinates, solution, primitives, etc. which then allows point-wise or row-wise access to the data (read or write). We can extend it to also expose derivative information.
For example:
PR Checklist