Skip to content

[Feature / Option] Vorticity Confinement (VC) technique to reduce numerical diffusion#1854

Merged
pcarruscag merged 29 commits intosu2code:developfrom
josy-nal:feature_vorticity_confinement
Jan 9, 2023
Merged

[Feature / Option] Vorticity Confinement (VC) technique to reduce numerical diffusion#1854
pcarruscag merged 29 commits intosu2code:developfrom
josy-nal:feature_vorticity_confinement

Conversation

@josy-nal
Copy link
Contributor

@josy-nal josy-nal commented Dec 24, 2022

Proposed Changes

Give a brief overview of your contribution here in a few sentences.

Implemented the option for vorticity confinement technique as a feature branch on the latest su2code/SU2:develop branch.

Descretized schemes offer numerical diffusion which results in lower resolution and accuracy in solution. This issue is especially observed in vortex dominated flows. A fine mesh will be necessary to get a solution with good accuracy. This increases the computation time and cost. A better technique is required which provides reasonably good accuracy without increasing the computation time and costs much.

Vorticity confinement technique is a proven procedure that helps in reducing numerical diffusion offered by the scheme. Results from the literature shows that using the vorticity confinement technique, a better resolution is achieved in the problems like flow behind bluff bodies, rotors, wings etc.

References

J. Steinhoff and D. Underhill, ``Modification of the euler equations for vorticity confinement: Application to the computation of interacting vortex rings,'' Physics of Fluids, vol.6, no.8, pp. 2738--2744, 1994. https://doi.org/10.1063/1.868164

D. A. Caughey and M. M. Hafez, Frontiers of Computational Fluid Dynamics 2006. WORLD SCIENTIFIC, 2005. https://www.worldscientific.com/doi/abs/10.1142/5963

R. Loehner and C. Yang, Vorticity confinement on unstructured grids, 40th AIAA Aerospace Sciences Meeting & Exhibit, 2002. [Online]. Available: https://arc. aiaa.org/doi/abs/10.2514/6.2002-137

A. Povitsky and K. C. Pierson, ``Vorticity confinement applied to accurate prediction of convection of wing tip vortices and induced drag,'' International Journal of Computational Fluid Dynamics, vol. 35, no. 3, pp. 143--156, 2021. https://doi.org/10.1080/10618562.2020.1856822

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

Copy link
Contributor

@chanduyal chanduyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a contributor, I'm fine with this pull request.

Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to SU2 and thank you for this contribution, it looks good, minor cleanups and simplifications are suggested below.
Do you have some case where this was particularly useful that you could add to our V&V collection (https://su2code.github.io/vandv/home/)?

Is this technique also applicable to incompressible flows? If so please consider adding it to CIncEulerSolver too.

In CConfig::SetPosprocessing you should check for features that exclude the use of this source term and throw an error. Currently is it not compatible with the following:

  • Incompressible
  • NEMO
  • Axisymmetry

@pcarruscag
Copy link
Member

Ah yes, please add yourselves to AUTHORS.md

josy-nal and others added 14 commits December 24, 2022 13:04
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
@josy-nal
Copy link
Contributor Author

Thank you very much for all the suggestions. Have tried to address all of them. Do let us know if these are acceptable. Regards.

@josy-nal
Copy link
Contributor Author

Thank you for the correction.

@josy-nal
Copy link
Contributor Author

Do let us know what we have to do next. We may be out of action for 3--4 days and get back to you for further process. Best regards.

@pcarruscag
Copy link
Member

Hi, thank you for making the changes, please have another look at the questions in the main comment from my review + my comment from today + my older comment regarding AUTHORS.md

@josy-nal
Copy link
Contributor Author

josy-nal commented Jan 8, 2023

Thank you very much for the gracious PR review approval.

@pcarruscag pcarruscag merged commit 9b7190d into su2code:develop Jan 9, 2023
@josy-nal
Copy link
Contributor Author

Thank you.

@tnv-nal
Copy link
Contributor

tnv-nal commented Jan 10, 2023

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants