OptimalPropeller function cleanup#1846
Merged
pcarruscag merged 13 commits intosu2code:developfrom Jan 13, 2023
Merged
Conversation
Member
|
Welcome to SU2 and thank you for your contribution. Is there something else you want to do in this PR? If not, please have a look at the CodeQL alert and then we can merge. |
Contributor
Author
|
Hello, sorry last week I did not had time to continue to work on it. If it is OK for you, I will make a few other changes between today and tomorrow, that could improve the code and then I think we could merge it. |
Contributor
Author
|
@pcarruscag could you run the workflow again, I made some small modifications, but now I cannot see the CodeQL alert anymore |
pcarruscag
approved these changes
Dec 29, 2022
Member
pcarruscag
left a comment
There was a problem hiding this comment.
Add yourself to AUTHORS.md (in the root of the repo) please
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
I used the OptimalPropeller function for another project a saw a lot of code that could be cleanup in order to be a bit more pythonic and easy to read.
Related Work
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.