[WIP]feature_coolprop thermodynamics model#1814
Merged
pcarruscag merged 4 commits intosu2code:feature_coolpropfrom Nov 11, 2022
Merged
[WIP]feature_coolprop thermodynamics model#1814pcarruscag merged 4 commits intosu2code:feature_coolpropfrom
pcarruscag merged 4 commits intosu2code:feature_coolpropfrom
Conversation
Contributor
Author
|
Hi, I add an error if CoolProp is used with non-dimensionalization in CConfig::SetPostprocessing. But when I try to run simulation with: SU2 is running well. Could you please help find the reason why the new codes in CConfig::SetPostprocessing. does work. Thank you. |
pcarruscag
reviewed
Nov 10, 2022
pcarruscag
reviewed
Nov 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This project aims to couple the free and open-source thermodynamics library CoolProp with SU2.
There are two advantages:
CoolProp can provide accurate thermodynamics properties (P, T, rho, ect) of commone fluids by either extracting experiment data from published papers, or computing based on the state-of-the-art Helmholtz energy formulations.
So, thermodynamics properties obtained from CoolProp should be more accurate than those obtained from Van der Waals or peng robinson gas model embedded in SU2. Also, the numerical results should be more accurate.
To use CoolProp feature, the ony input from the user is the name of fluid. Then all other thermodynamics can be provided by CoolProp.
%FLUID_MODEL = COOLPROP
%FLUID_NAME = nitrogen
Related Work
This project references the following work:
1.the work of coupling 'Mutationpp' with SU2.
4. the pull request of 'Feature nppr gas #1718'
PR Checklist