Conversation
|
license did not change, so no need to update that file. |
|
I wonder if maybe it would be a better idea to delete this (and other stuff) from externals/ and add it to subrojects/ instead. You can use |
|
It's a bit more involved because we want to support "offline" mode. But that's what we do with dependencies that we cannot copy due to license restrictions. With that said Nijso has probably fought enough with unit tests for the rest of the year, so if you want to send a pull request our way you are most welcome :) |
|
Offline mode could be done by creating source code tarballs as release artifacts instead of using github's autogenerated archives. Meson has a built-in tool for this, which automatically includes offline copies of used subprojects: |
Proposed Changes
Give a brief overview of your contribution here in a few sentences.
updated catch.hpp from the catchorg github repository
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.