Add look-up table class by bigfooted · Pull Request #1637 · su2code/SU2

bigfooted · 2022-05-16T22:16:23Z

Proposed Changes

Give a brief overview of your contribution here in a few sentences.
Adds the functionality of reading fluid data from an unstructured triangulated lookup table and interpolating. No coupling with a solver (combustion) yet, at this point we will only add a verification test

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
We split #1223 into smaller chunks

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

I am submitting my contribution to the develop branch.
My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
My contribution is commented and consistent with SU2 style.
I have added a test case that demonstrates my contribution, if necessary.
[] I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

bigfooted · 2022-05-16T22:26:39Z

At this stage, I'd like to add only the functionality of reading and interpolating a lookuptable, without immediately implementing a combustion solver that uses it.
I'd like to add a small verification test, would this be implemented in the MMS?

lgtm-com · 2022-05-16T23:43:17Z

This pull request introduces 1 alert when merging 1202a60 into 2ce680a - view on LGTM.com

new alerts:

1 for FIXME comment

pcarruscag · 2022-05-17T11:51:09Z

The test would go in UnitTests

SU2_CFD/include/numerics/CFileReaderLUT.hpp

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

lgtm-com · 2022-05-17T16:00:21Z

This pull request introduces 1 alert when merging c439501 into 6ca6ec2 - view on LGTM.com

new alerts:

1 for FIXME comment

lgtm-com · 2022-05-18T11:23:21Z

This pull request introduces 1 alert when merging 9bb027f into 6ca6ec2 - view on LGTM.com

new alerts:

1 for FIXME comment

lgtm-com · 2022-05-20T06:40:05Z

This pull request introduces 1 alert when merging 0b7fdb0 into da4c75d - view on LGTM.com

new alerts:

1 for FIXME comment

lgtm-com · 2022-05-21T14:29:49Z

This pull request introduces 1 alert when merging 7cb4919 into f15fe75 - view on LGTM.com

new alerts:

1 for FIXME comment

lgtm-com · 2022-05-24T22:07:19Z

This pull request introduces 1 alert when merging 1b00541 into 7a57336 - view on LGTM.com

new alerts:

1 for FIXME comment

lgtm-com · 2022-05-27T21:51:21Z

This pull request introduces 1 alert when merging f4186f6 into ead83fe - view on LGTM.com

new alerts:

1 for FIXME comment

SU2_CFD/include/numerics/CFileReaderLUT.hpp

SU2_CFD/include/numerics/CLookUpTable.hpp

SU2_CFD/src/numerics/CTrapezoidalMap.cpp

pcarruscag · 2022-05-27T22:30:52Z

SU2_CFD/src/numerics/CTrapezoidalMap.cpp

+CTrapezoidalMap::CTrapezoidalMap(vector<su2double> const& samples_x, vector<su2double> const& samples_y,
+                                 vector<vector<unsigned long> > const& edges,


clang format

clang-format says this is OK. What would you like this to be? Every argument on a line when the list of arguments is too long? Would you like to see the behavior of:
BinPackParameters:false
If false, a function declaration’s or function definition’s parameters will either all be on the same line or will have one line each.

Having the const first, but if clang format doesn't complain it's fine I guess, even if not super consistent.

I noticed that BinPackParameters:false does this (put const in front) as well, maybe we should add it to .clang-format?

SU2_CFD/src/numerics/CTrapezoidalMap.cpp

SU2_CFD/src/numerics/CLookUpTable.cpp

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

pcarruscag

Ah I think I forgot yesterday, these files would be better in common/*/containers

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Common/include/containers/CFileReaderLUT.hpp

Common/include/containers/CLookUpTable.hpp

Common/include/containers/CTrapezoidalMap.hpp

Common/include/containers/CLookUpTable.hpp

Common/src/containers/CLookUpTable.cpp

Common/src/containers/CTrapezoidalMap.cpp

UnitTests/Common/containers/CLookupTable_tests.cpp

UnitTests/Common/containers/lookuptable.drg

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

…ss functions const

Common/include/containers/CLookUpTable.hpp

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

…into feature_lookuptable

initial commit, adding files

4aab1e4

bigfooted added the PR: draft label May 16, 2022

added files to makefile and meson

1202a60

pr-triage bot removed the PR: draft label May 16, 2022

bigfooted added 2 commits May 17, 2022 13:44

run through clang-format

8d88fa9

end files with newline

15fb1aa

pcarruscag reviewed May 17, 2022

View reviewed changes

SU2_CFD/include/numerics/CFileReaderLUT.hpp Outdated Show resolved Hide resolved

bigfooted and others added 2 commits May 17, 2022 14:15

Update SU2_CFD/include/numerics/CFileReaderLUT.hpp

d69b5a7

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

namespace to header file

c439501

Merge branch 'develop' into feature_lookuptable

9bb027f

Merge branch 'develop' into feature_lookuptable

0b7fdb0

Merge branch 'develop' into feature_lookuptable

7cb4919

Merge branch 'develop' into feature_lookuptable

1b00541

Merge branch 'develop' into feature_lookuptable

f4186f6

pcarruscag reviewed May 27, 2022

View reviewed changes

bigfooted and others added 3 commits May 28, 2022 09:19

Update SU2_CFD/include/numerics/CFileReaderLUT.hpp

9bc6b93

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/include/numerics/CLookUpTable.hpp

906a5e6

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/src/numerics/CLookUpTable.cpp

e6ac5d4

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

pcarruscag reviewed May 28, 2022

View reviewed changes

bigfooted and others added 2 commits May 28, 2022 10:53

Update SU2_CFD/include/numerics/CLookUpTable.hpp

b47cec2

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/src/numerics/CTrapezoidalMap.cpp

5ee571d

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Merge branch 'develop' into feature_lookuptable

f4c1764

pcarruscag added the changelog:feature label Jul 23, 2022

pcarruscag changed the title ~~Feature lookuptable~~ Add look-up table class Jul 23, 2022

pcarruscag reviewed Jul 23, 2022

View reviewed changes

bigfooted and others added 11 commits July 24, 2022 12:57

Update Common/include/containers/CFileReaderLUT.hpp

b488130

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update Common/include/containers/CLookUpTable.hpp

00f9228

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update Common/include/containers/CLookUpTable.hpp

c62c730

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update Common/include/containers/CTrapezoidalMap.hpp

45667a8

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update Common/include/containers/CLookUpTable.hpp

9d153ba

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update Common/include/containers/CLookUpTable.hpp

a92573b

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update Common/include/containers/CTrapezoidalMap.hpp

0b6147e

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update UnitTests/Common/containers/CLookupTable_tests.cpp

4246b8c

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update Common/src/containers/CFileReaderLUT.cpp

4cbc4fa

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

added descriptions of class functions, used mpi::wtime, make some cla…

6b862f1

…ss functions const

remove using namespace std

3c0d0fb

pcarruscag reviewed Jul 25, 2022

View reviewed changes

Common/include/containers/CLookUpTable.hpp Outdated Show resolved Hide resolved

Common/include/containers/CLookUpTable.hpp Outdated Show resolved Hide resolved

bigfooted and others added 9 commits July 25, 2022 08:02

Update Common/include/containers/CLookUpTable.hpp

1e49f4f

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update Common/include/containers/CLookUpTable.hpp

933fa7a

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

added additional info, removed lookup table identifier

3bd230d

Merge branch 'feature_lookuptable' of https://github.com/su2code/SU2 …

67ab22c

…into feature_lookuptable

fix const

570163c

fix lookuptable_test roundoff value

3bf6243

fix lookuptable_test roundoff value

def34ab

fix lookuptable_test roundoff value

e3d15ce

remove namespace std

50fcedd

pcarruscag approved these changes Jul 29, 2022

View reviewed changes

bigfooted merged commit b01a639 into develop Aug 5, 2022

bigfooted deleted the feature_lookuptable branch August 5, 2022 16:38

pr-triage bot added PR: merged and removed PR: unreviewed labels Aug 5, 2022

		CTrapezoidalMap::CTrapezoidalMap(vector<su2double> const& samples_x, vector<su2double> const& samples_y,
		vector<vector<unsigned long> > const& edges,

Conversation

bigfooted commented May 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Related Work

PR Checklist

Uh oh!

bigfooted commented May 16, 2022

Uh oh!

lgtm-com bot commented May 16, 2022

Uh oh!

pcarruscag commented May 17, 2022

Uh oh!

Uh oh!

lgtm-com bot commented May 17, 2022

Uh oh!

lgtm-com bot commented May 18, 2022

Uh oh!

lgtm-com bot commented May 20, 2022

Uh oh!

lgtm-com bot commented May 21, 2022

Uh oh!

lgtm-com bot commented May 24, 2022

Uh oh!

lgtm-com bot commented May 27, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pcarruscag May 27, 2022

Choose a reason for hiding this comment

Uh oh!

bigfooted May 30, 2022

Choose a reason for hiding this comment

Uh oh!

pcarruscag May 30, 2022

Choose a reason for hiding this comment

Uh oh!

bigfooted May 30, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pcarruscag left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bigfooted commented May 16, 2022 •

edited

Loading