Composition-dependent density model for variable density incompressible flow by Cristopher-Morales · Pull Request #1620 · su2code/SU2

Cristopher-Morales · 2022-04-29T10:27:31Z

Proposed Changes

Give a brief overview of your contribution here in a few sentences.

Adapting and fixing mixing density model when species transport equations are being solved.
The species dependent properties will be added in 3 PRs:
1/3 : mixture density model (this PR)
2/3 : mixture viscosity + heat capacity
3/3 : mixture mass diffusivity + thermal conductivity

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
Mark Heimgartner implemented the MIXTURE_FLUID model during his master thesis at Bosch. In this pull request, we aim to adapt his implementation to the latest version of develop branch, fixing some implementations that we think were causing numerical issues in his original implementation.

EDIT: Here, the mixture density will be implemented, based on the ideal gas law (computing mixture molecular weights).

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

[X ] I am submitting my contribution to the develop branch.
[ X] My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
[ X] My contribution is commented and consistent with SU2 style.
I have added a test case that demonstrates my contribution, if necessary.
I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

…converge

lgtm-com · 2022-04-29T11:27:34Z

This pull request fixes 1 alert when merging c970543 into 6acc62f - view on LGTM.com

fixed alerts:

1 for Dead code due to goto or break statement

pcarruscag

Looks good.

Common/src/CConfig.cpp

Common/include/CConfig.hpp

Common/src/CConfig.cpp

SU2_CFD/include/fluid/CConstantSchmidt.hpp

SU2_CFD/include/fluid/CFluidModel.hpp

SU2_CFD/include/fluid/CFluidScalar.hpp

SU2_CFD/include/fluid/CIncIdealGasPolynomial.hpp

SU2_CFD/src/fluid/CFluidScalar.cpp

SU2_CFD/src/solvers/CIncEulerSolver.cpp

lgtm-com · 2022-04-30T10:09:59Z

This pull request fixes 1 alert when merging e8d75bc into 6acc62f - view on LGTM.com

fixed alerts:

1 for Dead code due to goto or break statement

bigfooted · 2022-05-01T09:37:33Z

@Cristopher-Morales do we really need all the diffusivity model implementations at this point (constant Schmidt etc)?
If the goal here is to push mixture density only, then these additional files can be in a separate pull request.

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

… into feature_mixturedensity

lgtm-com · 2022-05-10T09:18:10Z

This pull request fixes 1 alert when merging 69ba724 into fa910a0 - view on LGTM.com

fixed alerts:

1 for Dead code due to goto or break statement

lgtm-com · 2022-05-10T15:29:48Z

This pull request fixes 1 alert when merging f49c522 into fa910a0 - view on LGTM.com

fixed alerts:

1 for Dead code due to goto or break statement

Common/include/CConfig.hpp

Common/include/option_structure.hpp

Common/src/CConfig.cpp

SU2_CFD/src/fluid/CFluidScalar.cpp

SU2_CFD/src/solvers/CIncNSSolver.cpp

SU2_CFD/src/variables/CIncNSVariable.cpp

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

pcarruscag · 2022-06-04T09:49:07Z

...Cases/species_transport/venturi_primitive_3species/species2_primitiveVenturi_mixingmodel.cfg

+%
+FLUID_MODEL= FLUID_MIXTURE
+%
+MOLECULAR_WEIGHT= 28.96, 16.043


We need some comments here and in config_template regarding how this works, i.e. the "N+1" requirement and how they should be ordered.

ok, I will add them. Thank you so much for the feedback

lgtm-com · 2022-06-07T12:57:48Z

This pull request fixes 1 alert when merging a2f682e into 0232486 - view on LGTM.com

fixed alerts:

1 for Dead code due to goto or break statement

lgtm-com · 2022-06-07T14:09:46Z

This pull request fixes 1 alert when merging 98c61f0 into 0232486 - view on LGTM.com

fixed alerts:

1 for Dead code due to goto or break statement

lgtm-com · 2022-06-08T08:38:15Z

This pull request fixes 1 alert when merging 9dd6ea1 into c101e20 - view on LGTM.com

fixed alerts:

1 for Dead code due to goto or break statement

Cristopher-Morales · 2022-06-09T09:09:33Z

Hi all, thank you so much for your feedback. Are there things left for this pull request?
Thank you so much in advance.

lgtm-com · 2022-06-09T10:09:09Z

This pull request fixes 1 alert when merging 2b048b1 into c101e20 - view on LGTM.com

fixed alerts:

1 for Dead code due to goto or break statement

Common/src/CConfig.cpp

SU2_CFD/include/fluid/CFluidScalar.hpp

SU2_CFD/src/fluid/CFluidScalar.cpp

SU2_CFD/include/fluid/CFluidModel.hpp

Common/include/CConfig.hpp

Co-authored-by: TobiKattmann <31306376+TobiKattmann@users.noreply.github.com>

lgtm-com · 2022-06-10T13:38:01Z

This pull request fixes 1 alert when merging 4776aec into c101e20 - view on LGTM.com

fixed alerts:

1 for Dead code due to goto or break statement

lgtm-com · 2022-06-13T08:55:02Z

This pull request fixes 1 alert when merging 0e404e3 into c101e20 - view on LGTM.com

fixed alerts:

1 for Dead code due to goto or break statement

TobiKattmann

Hi Christopher, thanks for working on this and taking the responsibility to bring that contribution into develop 💐 (and of course working through all the comments, especially where some of mine were not correct 👍 )

Apart from these 2 more suggestions this PR is good to go from my point of view

TestCases/parallel_regression.py

...Cases/species_transport/venturi_primitive_3species/species2_primitiveVenturi_mixingmodel.cfg

Co-authored-by: TobiKattmann <31306376+TobiKattmann@users.noreply.github.com>

…2_primitiveVenturi_mixingmodel.cfg Co-authored-by: TobiKattmann <31306376+TobiKattmann@users.noreply.github.com>

lgtm-com · 2022-06-16T14:41:45Z

This pull request fixes 1 alert when merging 2c0d6c1 into db8ea45 - view on LGTM.com

fixed alerts:

1 for Dead code due to goto or break statement

Cristopher-Morales added 8 commits April 13, 2022 11:15

13-04-2022 adding FUID_MIXTURE

8a21ffc

update thursday 14-04-2022

114d616

21-04-2022 CFluiscalar based on IncIdealGas

7b07934

21-04-2022 adding viscosity and thermal conductivity

5c42c60

22-04-2022 compiles and run for more than one species, but still not …

cf9e8f5

…converge

mixing density working 26-04-22

8ad117d

29-04-2022 cleaning up and compiling

9fb5a44

29-04-22

c970543

pr-triage bot added the PR: unreviewed label Apr 29, 2022

pcarruscag reviewed Apr 29, 2022

View reviewed changes

Merge branch 'develop' into feature_mixturedensity

e8d75bc

Cristopher-Morales and others added 6 commits May 10, 2022 09:23

Update Common/src/CConfig.cpp

5932361

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update Common/include/CConfig.hpp

5bd4b96

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

10-05-2022 fix comments

8e8a71d

Merge branch 'feature_mixturedensity' of https://github.com/su2code/SU2…

095c649

… into feature_mixturedensity

Merge branch 'develop' into feature_mixturedensity

750fe43

10-05-2022 removingSchmidth files

69ba724

10-05-2022 checking density model

f49c522

pcarruscag reviewed May 11, 2022

View reviewed changes

pcarruscag added the changelog:feature label May 12, 2022

pcarruscag changed the title ~~Feature mixturedensity~~ [WIP] Feature mixturedensity May 12, 2022

pr-triage bot removed the PR: unreviewed label May 12, 2022

Cristopher-Morales and others added 3 commits May 13, 2022 09:55

Update Common/include/CConfig.hpp

cc1b1bd

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update Common/include/option_structure.hpp

b44f2a1

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update Common/src/CConfig.cpp

37ee38b

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

pcarruscag reviewed Jun 4, 2022

View reviewed changes

Merge branch 'develop' into feature_mixturedensity

a2f682e

adding explanaction test and config_template.cfg files

98c61f0

Merge branch 'develop' into feature_mixturedensity

9dd6ea1

removing CDiffusivityModel.hpp file

2b048b1

TobiKattmann reviewed Jun 10, 2022

View reviewed changes

Cristopher-Morales and others added 4 commits June 10, 2022 14:32

Update SU2_CFD/include/fluid/CFluidScalar.hpp

83ab514

Co-authored-by: TobiKattmann <31306376+TobiKattmann@users.noreply.github.com>

Update SU2_CFD/src/fluid/CFluidScalar.cpp

5281887

Co-authored-by: TobiKattmann <31306376+TobiKattmann@users.noreply.github.com>

Update Common/include/CConfig.hpp

7344cba

Co-authored-by: TobiKattmann <31306376+TobiKattmann@users.noreply.github.com>

Update Common/include/CConfig.hpp

4776aec

Co-authored-by: TobiKattmann <31306376+TobiKattmann@users.noreply.github.com>

clang-format

0e404e3

TobiKattmann approved these changes Jun 15, 2022

View reviewed changes

TestCases/parallel_regression.py Outdated Show resolved Hide resolved

...Cases/species_transport/venturi_primitive_3species/species2_primitiveVenturi_mixingmodel.cfg Outdated Show resolved Hide resolved

Cristopher-Morales and others added 3 commits June 16, 2022 15:41

Update TestCases/parallel_regression.py

d593eb3

Co-authored-by: TobiKattmann <31306376+TobiKattmann@users.noreply.github.com>

Update TestCases/species_transport/venturi_primitive_3species/species…

3a73f6d

…2_primitiveVenturi_mixingmodel.cfg Co-authored-by: TobiKattmann <31306376+TobiKattmann@users.noreply.github.com>

Merge branch 'develop' into feature_mixturedensity

2c0d6c1

Cristopher-Morales merged commit f4a64c3 into develop Jun 16, 2022

Cristopher-Morales deleted the feature_mixturedensity branch June 16, 2022 14:42

pr-triage bot added PR: merged and removed PR: unreviewed labels Jun 16, 2022

Cristopher-Morales mentioned this pull request Jun 28, 2022

Composition-dependent viscosity and thermal conductivity models for incompresible flows #1690

Merged

3 tasks

This was referenced Sep 13, 2022

[WIP] Composition-dependent heat capacities and mass diffusivity models for incompresible flows #1758

Closed

Composition-dependent heat capacities and mass diffusivity models for incompresible flows #1762

Merged

Conversation

Cristopher-Morales commented Apr 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Related Work

PR Checklist

Uh oh!

lgtm-com bot commented Apr 29, 2022

Uh oh!

pcarruscag left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lgtm-com bot commented Apr 30, 2022

Uh oh!

bigfooted commented May 1, 2022

Uh oh!

lgtm-com bot commented May 10, 2022

Uh oh!

lgtm-com bot commented May 10, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pcarruscag Jun 4, 2022

Choose a reason for hiding this comment

Uh oh!

Cristopher-Morales Jun 7, 2022

Choose a reason for hiding this comment

Uh oh!

lgtm-com bot commented Jun 7, 2022

Uh oh!

lgtm-com bot commented Jun 7, 2022

Uh oh!

lgtm-com bot commented Jun 8, 2022

Uh oh!

Cristopher-Morales commented Jun 9, 2022

Uh oh!

lgtm-com bot commented Jun 9, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lgtm-com bot commented Jun 10, 2022

Uh oh!

lgtm-com bot commented Jun 13, 2022

Uh oh!

TobiKattmann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lgtm-com bot commented Jun 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

Cristopher-Morales commented Apr 29, 2022 •

edited

Loading