Fix WALL_TIME for unsteady + some variable index cleanup#1544
Merged
pcarruscag merged 1 commit intodevelopfrom Feb 13, 2022
Merged
Fix WALL_TIME for unsteady + some variable index cleanup#1544pcarruscag merged 1 commit intodevelopfrom
pcarruscag merged 1 commit intodevelopfrom
Conversation
bigfooted
reviewed
Feb 12, 2022
Comment on lines
216
to
219
| StartTime = SU2_MPI::Wtime(); | ||
|
|
||
| config_container[ZONE_0]->Set_StartTime(StartTime); | ||
| } | ||
|
|
||
| config_container[ZONE_0]->Set_StartTime(StartTime); | ||
| } |
Contributor
There was a problem hiding this comment.
Looks like this is the actual fix and the rest is code cleanup? LGTM
bigfooted
reviewed
Feb 12, 2022
| } | ||
|
|
||
| Density = V_outlet[nDim+2]; | ||
| Density = V_outlet[prim_idx.Density()]; |
Contributor
There was a problem hiding this comment.
Great to see the replacement of the magical numbers nDim + i with human readable indices
Contributor
|
💐 Thanks for the quick closure of this issue and of course the additional clean-up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1542