Output heatfluxes (total and maximum) per surface#1534
Merged
pcarruscag merged 5 commits intodevelopfrom Feb 4, 2022
Merged
Conversation
TobiKattmann
approved these changes
Feb 4, 2022
Contributor
TobiKattmann
left a comment
There was a problem hiding this comment.
Thanks @pcarruscag for tackling that issue, I saw it as well but pretended to haven't seen it :D
LGTM
My comments are minor things. The only real thing is that I think AVG_TEMPERATURE should be removed for the flow_solver
|
|
||
| if (heat || weakly_coupled_heat) { | ||
| AddHeatCoefficients(config); | ||
| AddHistoryOutput("AVG_TEMPERATURE", "Temp", ScreenOutputFormat::SCIENTIFIC, "HEAT", "Average temperature on all surfaces set with MARKER_MONITORING.", HistoryFieldType::COEFFICIENT); |
Contributor
There was a problem hiding this comment.
Just as a side note: For an AvgTemp OF for the flow solver one needs to use SURFACE_STATIC_TEMPERATURE (which works with MARKER_ANALYZE) and not AVG_TEMPERATURE. For solid domains it is AVG_TEMPERATURE though.
Member
Author
There was a problem hiding this comment.
What about weakly_coupled_heat?
Contributor
There was a problem hiding this comment.
Yep, you're right. There one would use AVG_TEMPERATURE
Member
Author
There was a problem hiding this comment.
🤦 I won't stick my hand in that xD
pcarruscag
commented
Feb 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1531