Merged
Conversation
And some other smaller comment updates/ cleanup.
They were commented out with the remark of "Serious convergence issues" in the turbulence solver already ages ago. I.e. this has to be tackeled as a little project. Then at best for Turbulence as well. Note, for inc mean flow, these contribuions are present
Signed-off-by: jtneedels <jneedels@stanford.edu>
…nt treatement. - Solver works on mesh and design parameter level. - Can smooth the discrete adjoint gradient. - Support for printing the combined system matrix (Laplace-Beltrami operator). - Squashed old commits into new branch based on version 7.2.1 develop.
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Declaring vars were needed. More const. Indentation.
… Sobolev smoothing solver.
Comp/Inc/Nemo kept exactly the same output for Turb stuff in their respective outputs. That is now collected and moved to the parent class. I hope the accesses to the data is the same between the 3 classes ... otherwise it wont work
One noticed small downside to this operation is that during the dry run the turb quantities are written collectively close to the end when the respective function is called. Before ALL the RMS_RES were listed close to each other.
And some other smaller comment updates/ cleanup.
Declaring vars were needed. More const. Indentation.
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Made sure to keep the original order, such that restarts work the same as before.
Clean LoadRestart for Flow/Turb/Heat
Including Res+Jacobian Zeroing and gradient+limiter computation
RMS_RES, MAX_RES, BGS_RES, TurbLINSOL are all written in separate functions.
Fix still failing cross compilation
Use pregenerated files for cross-compilation of hdf5
…_hdf5_cross_compile
Su2 hdf5 cross compile add missing meson keyword
Upgrade to meson 0.61.1
Correct generator dependence for hdf5.
Use correct target_machine check for hdf5 cross compilation
…lver Add a Sobolev smoothing method to the discrete adjoint gradient calculation.
Copyright 2022
Changing version number to 7.3.0
|
This pull request introduces 3 alerts and fixes 45 when merging f8da293 into 5655d91 - view on LGTM.com new alerts:
fixed alerts:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.