Merged
Conversation
Applied via clang-format -i -style=file filename. Wrong indentations for vars sharing the same type. One space indentations of protected, public keywords.
…nto feature_scalarbase
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Refactor CPrimalGrid classes
For SST the stored solution is just k,w. The transported var rho*k or rho*w, respectively, is conservative . So the solution to the linear system in implicit time-stepping is an update to the conservative vars so that needs to be taken into account. The class bool Conservative triggers this multiplication/division by rho. For e.g. SA this bool is false. The TansLM solver uses its own Implicit update function, therefore this does not apply. Note though that it seems that the transported and Solution var are conservative, which is yet another case. fml
Added lambda that adds density to vector of Solution. If Conservative=true. Dynamic grid part should work but not looked at further.
Solver. Unified AddClipped/ConservativeSolution to incoporate both cases with default values.
fix bug axisym source term + update regression cases
Cleanup ASCII mesh reader
I wont change the output_structure_legacy though
This reverts commit 8f3087b.
Implicit solver for inviscid NEMO problems
…override." This reverts commit 67c1aa9.
Minor chores: TURB_MODEL now enum class.
…into fix_wallfunctions
Cleanup wall functions and add user controls
* update xcode with new files * update xcode 2
Fix grid velocity output for dynamic mesh (with option DEFORM_MESH)
Changing version number to 7.2.1
Contributor
|
👍 https://github.com/su2code/SU2/releases/tag/v7.2.1 I am just curious: was this splitting in features, bug fixes and maintenance a manual task or did some script fail to do that? |
|
This pull request introduces 2 alerts and fixes 29 when merging b718c1f into a1a88d1 - view on LGTM.com new alerts:
fixed alerts:
|
Member
Author
|
I'll need to investigate what went wrong, but the auto-generated list was not complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.