Skip to content

update master#1416

Merged
pcarruscag merged 484 commits intomasterfrom
develop
Oct 29, 2021
Merged

update master#1416
pcarruscag merged 484 commits intomasterfrom
develop

Conversation

@pcarruscag
Copy link
Member

No description provided.

TobiKattmann and others added 30 commits August 27, 2021 15:22
Applied via clang-format -i -style=file filename.
Wrong indentations for vars sharing the same type.
One space indentations of protected, public keywords.
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
For SST the stored solution is just k,w. The transported var rho*k or
rho*w, respectively, is conservative . So the solution to the linear
system in implicit time-stepping is an update to the conservative vars
so that needs to be taken into account. The class bool Conservative
triggers this multiplication/division by rho. For e.g. SA this bool is
false.
The TansLM solver uses its own Implicit update function, therefore this
does not apply. Note though that it seems that the transported and
Solution var are conservative, which is yet another case. fml
Added lambda that adds density to vector of Solution.
If Conservative=true.
Dynamic grid part should work but not looked at further.
Solver.

Unified AddClipped/ConservativeSolution to incoporate both cases with
default values.
fix bug axisym source term + update regression cases
TobiKattmann and others added 21 commits October 17, 2021 13:50
I wont change the output_structure_legacy though
Implicit solver for inviscid NEMO problems
Minor chores: TURB_MODEL now enum class.
Cleanup wall functions and add user controls
* update xcode with new files

* update xcode 2
Fix grid velocity output for dynamic mesh (with option DEFORM_MESH)
Changing version number to 7.2.1
@pcarruscag pcarruscag merged commit 5655d91 into master Oct 29, 2021
@TobiKattmann
Copy link
Contributor

👍 https://github.com/su2code/SU2/releases/tag/v7.2.1 I am just curious: was this splitting in features, bug fixes and maintenance a manual task or did some script fail to do that?

@lgtm-com
Copy link

lgtm-com bot commented Oct 29, 2021

This pull request introduces 2 alerts and fixes 29 when merging b718c1f into a1a88d1 - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Variable defined multiple times

fixed alerts:

  • 13 for Variable defined multiple times
  • 10 for Comparison of narrow type with wide type in loop condition
  • 6 for Unused import

@pcarruscag
Copy link
Member Author

I'll need to investigate what went wrong, but the auto-generated list was not complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.