[WIP] Test for adding in the implicit viscous solver for NEMO#1356
Closed
WallyMaier wants to merge 98 commits intodevelopfrom
Closed
[WIP] Test for adding in the implicit viscous solver for NEMO#1356WallyMaier wants to merge 98 commits intodevelopfrom
WallyMaier wants to merge 98 commits intodevelopfrom
Conversation
…into feature_NEMO_implicit
Signed-off-by: jtneedels <jneedels@stanford.edu>
…into feature_NEMO_implicit
This reverts commit 0b09437.
WallyMaier
commented
Aug 21, 2021
WallyMaier
commented
Aug 21, 2021
Contributor
Author
|
@pcarruscag, I hope this is the last question, it seems the Matrix<NSPECIES, NSPECIES> dJdr_I causes some issues : "subscripted value is neither array nor pointer nor vector" when trying to anything with it. However, it seems all the other matrices dont have any issues. Do you have any ideas? |
pcarruscag
reviewed
Oct 29, 2021
pcarruscag
reviewed
Oct 29, 2021
pcarruscag
reviewed
Oct 29, 2021
pcarruscag
reviewed
Oct 29, 2021
pcarruscag
reviewed
Oct 29, 2021
pcarruscag
reviewed
Oct 29, 2021
pcarruscag
reviewed
Oct 29, 2021
|
This pull request introduces 2 alerts when merging 471a34a into c531be4 - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging c0979aa into b718c1f - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging ab8db24 into b718c1f - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert and fixes 16 when merging 50c2352 into b718c1f - view on LGTM.com new alerts:
fixed alerts:
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR addresses adding in the Jacobians for the NEMO convective, viscous and source terms. Much improvement and testing is still needed, but I was hoping to get feedback on some coding methodologies/strategies to avoid code bloat, etc.
I would very much appreciate thoughts and feedback!
Related Work
This is a continuation of the recent NEMO improvements/modernization #1343 and #1347
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.