Nan checks and better discrete adjoint default options#1105
Merged
pcarruscag merged 6 commits intodevelopfrom Nov 18, 2020
Merged
Nan checks and better discrete adjoint default options#1105pcarruscag merged 6 commits intodevelopfrom
pcarruscag merged 6 commits intodevelopfrom
Conversation
oleburghardt
approved these changes
Nov 16, 2020
Contributor
oleburghardt
left a comment
There was a problem hiding this comment.
Looks good to me, give it a go on Wednesday.
I've seen some nans in forward AD mode recently (for maxHF), maybe this helps to not always ignore them..
TobiKattmann
approved these changes
Nov 17, 2020
…de/SU2 into nan_checks_better_defaults
Member
Author
|
Thank you both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Check for Nan in the monitored values of COutput (was already done for time domain).
For SU2_CFD_AD and SU2_DOT_AD the default MATH_PROBLEM becomes DISCRETE_ADJOINT
When the MATH_PROBLEM is DISCRETE_ADJOINT the linear solver and preconditioner of primal solvers is made the same as the DISCADJ_** ones, i.e. LINEAR_SOLVER and LINEAR_SOLVER_PREC are ignored (see why I think it makes sense in #942, and let me know if you think it doesn't make sense).
Related Work
#942
PR Checklist