Conversation
- Remove duplicate files from root directory (kept package versions in src/) - Move test files to tests/integration/ directory - Update imports to use package structure - Maintain stealth mode features in the consolidated codebase This change follows Python packaging best practices with src layout and separate test directory, making the project structure more maintainable and CI/CD friendly.
…t script execution
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a "Stealth Mode" feature that allows clients to connect to the server without spawning a visible avatar. Stealth clients can participate in the network (send/receive RPCs, access network variables) but their transforms are not broadcast to other clients and they don't appear in group transform messages.
- Stealth mode is detected by sending NaN values in all transform fields (physics, head, hands) as a handshake
- Server tracks stealth status and excludes stealth clients from transform broadcasts while including them in ID mappings
- Unity client automatically enables stealth mode when no local player prefab is assigned
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| NetSyncManager.cs | Added stealth mode detection, new API method, and enhanced logging |
| TransformSyncManager.cs | Added stealth handshake sending functionality |
| PlayerManager.cs | Modified client filtering to support stealth mode exclusion |
| MessageProcessor.cs | Added stealth mode tracking and detection logic |
| DataStructure.cs | Extended DeviceIdMapping to include stealth flag |
| BinarySerializer.cs | Added stealth handshake serialization and NaN detection |
| Demo-01.unity | Updated scene configuration and component setup |
| server.py | Enhanced server with stealth client detection and filtering |
| binary_serializer.py | Added stealth mode detection utilities and mapping serialization |
| test files | Added comprehensive stealth mode testing and integration tests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
STYLY-NetSync-Unity/Packages/com.styly.styly-netsync/Runtime/NetSyncManager.cs
Show resolved
Hide resolved
STYLY-NetSync-Unity/Packages/com.styly.styly-netsync/Runtime/Internal/BinarySerializer.cs
Show resolved
Hide resolved
STYLY-NetSync-Unity/Packages/com.styly.styly-netsync/Runtime/Internal/TransformSyncManager.cs
Outdated
Show resolved
Hide resolved
This was referenced Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature/stealth mode2