Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new Unity–Python feature parity rule to the code review guidelines for the NetSync project, ensuring that shared features between the Unity C# and Python clients remain synchronized. It also updates the repo-wide rules documentation to clarify counterpart mappings and review requirements. Additionally, there are minor updates to the Unity OpenXR settings asset, mainly adding new fields for compatibility with newer Unity versions.
Updates to code review guidelines and repo-wide rules:
.claude/skills/review-netsync/SKILL.md,.claude/skills/review-netsync/references/repo-wide-rules.md) [1] [2] [3].claude/skills/review-netsync/SKILL.md).claude/skills/review-netsync/references/repo-wide-rules.md)Unity project settings updates:
targetOpenXRApiVersionandcustomRuntimeLoaderNameto multiple entries in theOpenXR Package Settings.assetfile to maintain compatibility with newer Unity or OpenXR versions. These are boilerplate additions with no logic changes. (STYLY-NetSync-Unity/Assets/XR/Settings/OpenXR Package Settings.asset) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22] [23] [24] [25] [26] [27] [28] [29] [30]symmetricProjection→m_symmetricProjection) for consistency with Unity's serialization conventions. (STYLY-NetSync-Unity/Assets/XR/Settings/OpenXR Package Settings.asset)These changes help ensure that both Unity and Python clients remain in sync for all shared networking features and keep the Unity project settings up to date with evolving platform requirements.