Skip to content

Refactor code review skill#377

Merged
from2001 merged 3 commits intodevelopfrom
refactor/code-review-skill
Mar 14, 2026
Merged

Refactor code review skill#377
from2001 merged 3 commits intodevelopfrom
refactor/code-review-skill

Conversation

@from2001
Copy link
Collaborator

This pull request introduces a new Unity–Python feature parity rule to the code review guidelines for the NetSync project, ensuring that shared features between the Unity C# and Python clients remain synchronized. It also updates the repo-wide rules documentation to clarify counterpart mappings and review requirements. Additionally, there are minor updates to the Unity OpenXR settings asset, mainly adding new fields for compatibility with newer Unity versions.

Updates to code review guidelines and repo-wide rules:

  • Added a new section on Unity–Python feature parity to the NetSync code review skill, specifying that when a feature is added or modified in either the Unity C# or Python client, the corresponding counterpart must be updated if it shares functionality. Explicit mappings between Unity and Python files are provided, and the severity of missing updates is defined (WARNING or CRITICAL for protocol/serialization changes). (.claude/skills/review-netsync/SKILL.md, .claude/skills/review-netsync/references/repo-wide-rules.md) [1] [2] [3]
  • Expanded the code review checklist to include explicit steps for checking feature parity and clarified which files and changes require parity checks. (.claude/skills/review-netsync/SKILL.md)
  • Provided a detailed table of Unity–Python counterpart mappings and shared functionality areas in the repo-wide rules for easier reference. (.claude/skills/review-netsync/references/repo-wide-rules.md)

Unity project settings updates:

  • Added new fields such as targetOpenXRApiVersion and customRuntimeLoaderName to multiple entries in the OpenXR Package Settings.asset file to maintain compatibility with newer Unity or OpenXR versions. These are boilerplate additions with no logic changes. (STYLY-NetSync-Unity/Assets/XR/Settings/OpenXR Package Settings.asset) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22] [23] [24] [25] [26] [27] [28] [29] [30]
  • Renamed some serialized property names (e.g., symmetricProjectionm_symmetricProjection) for consistency with Unity's serialization conventions. (STYLY-NetSync-Unity/Assets/XR/Settings/OpenXR Package Settings.asset)

These changes help ensure that both Unity and Python clients remain in sync for all shared networking features and keep the Unity project settings up to date with evolving platform requirements.

@from2001 from2001 merged commit 1a19cb1 into develop Mar 14, 2026
@from2001 from2001 deleted the refactor/code-review-skill branch March 14, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant