feat: add --dealer-port and --pub-port CLI arguments#370
Merged
Conversation
Add --dealer-port and --pub-port CLI arguments to styly-netsync-server, consistent with the existing --server-discovery-port argument. CLI arguments take precedence over config file values (CLI > config > defaults). Closes #369 Co-authored-by: Masahiro Yamaguchi <from2001@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds CLI support for overriding the server’s ZeroMQ networking ports, wiring those values into config merging and extending config tests to cover the new behavior.
Changes:
- Add
--dealer-portand--pub-portCLI arguments to the server entrypoint. - Extend
merge_cli_args()to applydealer_port/pub_portoverrides when provided. - Add/adjust unit tests verifying port overrides and immutability of the base config.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
STYLY-NetSync-Server/tests/test_config.py |
Adds tests ensuring CLI port args override config and don’t mutate the original config object. |
STYLY-NetSync-Server/src/styly_netsync/server.py |
Introduces new CLI flags for dealer/pub ports using valid_port. |
STYLY-NetSync-Server/src/styly_netsync/config.py |
Updates CLI-to-config merge logic to include dealer/pub port fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
--dealer-portand--pub-portCLI arguments tostyly-netsync-server, consistent with the existing--server-discovery-portargument. CLI arguments take precedence over config file values (CLI > config > defaults).Closes #369
Generated with Claude Code