Conversation
Collaborator
Author
Issue: Disconnection Detection Failure with Stealth ClientsWhen only stealth clients remain in a room, the server fails to send an "empty room broadcast." Consequently, disconnection detection is never triggered on the client side. Reproduction Flow
# server.py:1810-1811
if not client_snapshot:
return None # Ends here without sending the broadcast
Why it works in "Normal Mode"In Normal Mode (where After Client B disconnects, the local client's transform data is still included in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #349
This pull request makes a small change to the
_serialize_room_transformmethod inSTYLY-NetSync-Server/src/styly_netsync/server.py, removing early returns that previously caused the function to returnNonewhen there were no client snapshots or when no client data was serialized. Now, the function always returns a serialized buffer, even if it is empty. [1] [2]