fix: update client mapping logic to exclude disconnected clients#350
Merged
fix: update client mapping logic to exclude disconnected clients#350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refines how device-to-client mappings are broadcasted for a room, ensuring that only currently connected clients are included. This prevents stale mappings for clients that have disconnected but whose device IDs are still present for reuse.
Improvements to client mapping accuracy:
_broadcast_id_mappingsmethod instyly_netsync/server.pyto only include mappings for clients that are still connected to the room, skipping any entries for clients that have been cleaned up but whose device IDs remain for reuse.Close #349