Skip to content

feat: add code review skill#339

Merged
from2001 merged 2 commits intodevelopfrom
feature/review-skill
Feb 16, 2026
Merged

feat: add code review skill#339
from2001 merged 2 commits intodevelopfrom
feature/review-skill

Conversation

@from2001
Copy link
Collaborator

Fix #338

This pull request introduces four new reference documents to the .claude/skills/code-review-netsync/references directory. These documents establish comprehensive code review guidelines for the repository, covering protocol change impact, Python server rules, Unity C# standards, and repo-wide practices. The addition provides clear checklists and best practices for reviewers and contributors, ensuring consistency, safety, and maintainability across the codebase.

Repository-wide standards and protocol impact:

  • Added protocol-change-checklist.md outlining a detailed impact checklist for protocol changes, including serialization parity, test requirements, simulator updates, server and Unity client handling, and mandatory documentation updates. Includes a review output template for protocol changes and a quick reference for protocol constants.
  • Added repo-wide-rules.md describing repository-wide code review rules, including ZeroMQ patterns, protocol details, backward compatibility, threading, performance, documentation, version management, git practices, CI/CD, and security.

Language-specific code review rules:

  • Added python-server-rules.md detailing Python server code review requirements: strict type annotations, formatting and linting standards, import organization, exception handling, logging, naming conventions, dataclass usage, constants/enums, test structure, and Python version requirements. Includes a pre-commit checklist.
  • Added unity-csharp-rules.md specifying Unity C# code review rules: null and thread safety, namespace conventions, private field naming, region organization, UnityEvent initialization, memory/GC optimization, inspector attributes, XML documentation, file structure, and .meta file handling.

@from2001 from2001 changed the title feat: add comprehensive protocol change impact checklist and review rules for Python and Unity feat: add code review skill Feb 15, 2026
@from2001 from2001 merged commit 237ce0a into develop Feb 16, 2026
@from2001 from2001 deleted the feature/review-skill branch February 16, 2026 12:53
@from2001
Copy link
Collaborator Author

code-review-skill_en

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code review skill

1 participant