Conversation
…ules for Python and Unity
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fix #338
This pull request introduces four new reference documents to the
.claude/skills/code-review-netsync/referencesdirectory. These documents establish comprehensive code review guidelines for the repository, covering protocol change impact, Python server rules, Unity C# standards, and repo-wide practices. The addition provides clear checklists and best practices for reviewers and contributors, ensuring consistency, safety, and maintainability across the codebase.Repository-wide standards and protocol impact:
protocol-change-checklist.mdoutlining a detailed impact checklist for protocol changes, including serialization parity, test requirements, simulator updates, server and Unity client handling, and mandatory documentation updates. Includes a review output template for protocol changes and a quick reference for protocol constants.repo-wide-rules.mddescribing repository-wide code review rules, including ZeroMQ patterns, protocol details, backward compatibility, threading, performance, documentation, version management, git practices, CI/CD, and security.Language-specific code review rules:
python-server-rules.mddetailing Python server code review requirements: strict type annotations, formatting and linting standards, import organization, exception handling, logging, naming conventions, dataclass usage, constants/enums, test structure, and Python version requirements. Includes a pre-commit checklist.unity-csharp-rules.mdspecifying Unity C# code review rules: null and thread safety, namespace conventions, private field naming, region organization, UnityEvent initialization, memory/GC optimization, inspector attributes, XML documentation, file structure, and.metafile handling.