fix: skip server version in device ID mapping deserialization#324
Merged
fix: skip server version in device ID mapping deserialization#324
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a critical bug in the device ID mapping deserialization logic. The function now correctly skips the 3-byte server version header (major, minor, patch) before parsing the mapping count and data, ensuring proper alignment with the serialization format defined in serialize_device_id_mapping.
Changes:
- Added offset increment of 3 bytes in
_deserialize_device_id_mappingto skip server version header
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a small but important change to the device ID mapping deserialization logic. The function now correctly skips the 3-byte server version at the start of the message before parsing the mappings, ensuring proper alignment for subsequent data extraction.