Fix Python client compatibility with ROUTER-based control messages#317
Closed
Copilot wants to merge 3 commits intofix/transform-sub-drain-rcvhwmfrom
Closed
Fix Python client compatibility with ROUTER-based control messages#317Copilot wants to merge 3 commits intofix/transform-sub-drain-rcvhwmfrom
Copilot wants to merge 3 commits intofix/transform-sub-drain-rcvhwmfrom
Conversation
- Poll both DEALER and SUB sockets in receive loop - DEALER receives control messages (RPC, NV, device mapping) from ROUTER - SUB receives transform broadcasts from PUB - Auto-send stealth handshake on start to register with server - Fix device ID mapping deserializer to skip 3-byte version header This resolves the protocol breaking change introduced when control messages were moved from PUB/SUB to ROUTER/DEALER unicast delivery. Co-authored-by: from2001 <387880+from2001@users.noreply.github.com>
- Move stealth handshake send after logger to avoid race condition - Make error handling consistent between DEALER and SUB socket processing Co-authored-by: from2001 <387880+from2001@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor NetSyncServer and ConnectionManager for priority-based sending
Fix Python client compatibility with ROUTER-based control messages
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The protocol change moving control messages from PUB/SUB to ROUTER/DEALER broke the Python client, which only polled the SUB socket. The client couldn't receive RPC, Network Variables, or Device ID mappings, but tests passed due to missing assertions.
Changes
Python Client (
client.py)Binary Serializer (
binary_serializer.py)Example
Before (broken):
After (fixed):
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.