Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request improves the REST bridge startup logging to display the actual server IP address instead of the generic "0.0.0.0", and reduces Uvicorn log verbosity by changing the log level from "info" to "warning".
Changes:
- Modified
Server.start()method to accept an optionalip_addressesparameter for flexible IP configuration - Updated REST bridge startup log message to display the first detected IP address when available
- Changed Uvicorn log level from "info" to "warning" to reduce log verbosity
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
STYLY-NetSync-Server/src/styly_netsync/server.py |
Added optional ip_addresses parameter to start() method, updated REST bridge log to show actual IP address, and passed IP addresses from main() to start() |
STYLY-NetSync-Server/src/styly_netsync/rest_bridge.py |
Changed Uvicorn log level from "info" to "warning" to reduce verbosity |
STYLY-NetSync-Server/tests/test_all_run_methods.py |
Reformatted assertion for improved readability (no functional change) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to server startup flexibility and logging clarity, along with a minor adjustment to test assertion formatting. The most significant changes are grouped below.
Server startup and logging improvements:
startmethod inServernow accepts an optionalip_addressesparameter, allowing for more flexible IP address configuration during server startup.mainfunction is updated to pass theip_addressesargument toserver.start, ensuring the new functionality is utilized during server initialization."info"to"warning", reducing log verbosity during normal operation.Test formatting:
test_server_with_custom_discovery_portfor improved readability.Close #270