fix: update uvicorn dependency to remove optional extras#268
Merged
fix: update uvicorn dependency to remove optional extras#268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for Windows ARM64 Installation Error
Problem
When installing styly-netsync-server on Windows ARM64 using uvx styly-netsync-server@0.7.1, the installation fails with:
error: Microsoft Visual C++ 14.0 or greater is required.
This occurs because httptools (a C extension package) doesn't provide pre-built wheels for Windows ARM64, so it tries to compile from source—which requires Visual C++ Build Tools.
Root Cause
The dependency chain:
styly-netsync-server → uvicorn[standard] → httptools
The [standard] extra in uvicorn includes optional performance dependencies like httptools and uvloop, which contain C extensions.
Solution
Changed in pyproject.toml:41:
Impact
The [standard] extra provided:
httptools - Faster HTTP parsing (C extension)
uvloop - Faster event loop (Unix-only, not used on Windows anyway)
watchfiles - File watching for auto-reload
These are performance optimizations only. The server works correctly without them using Python's built-in asyncio and the pure-Python HTTP parser.