[Breaking change] Remove VR/MR switching methods and passthrough code from NetSyncManager by Copilot · Pull Request #264 · styly-dev/STYLY-NetSync

Copilot · 2026-01-08T00:53:38Z

Summary

Successfully removed all VR/MR switching methods and passthrough-related code from NetSyncManager as requested. The changes include:

Removed 4 methods from NetSyncManager.cs (2 public, 2 internal)
Removed 2 RPC case handlers
Removed PassthroughMode property and passthroughMode field
Deleted SwitchVRMR.cs sample script and its meta file
Cleaned up Demo-01.unity scene to remove the GameObject that used the removed script
Updated README.md documentation and removed empty section

Total lines removed: 165 lines across 5 files

Original prompt

This section details on the original issue you should resolve

<issue_title>Remove switching VR/MR methods from NetSync</issue_title>
<issue_description>Remove these functions.
NetSyncManager.Instance.SwitchToVR
NetSyncManager.Instance.SwitchToMR</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes Remove switching VR/MR methods from NetSync #256

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: from2001 <387880+from2001@users.noreply.github.com>

from2001 · 2026-01-08T01:03:13Z

@claude Review this PR.

claude · 2026-01-08T01:03:24Z

Claude finished @from2001's task in 1m 14s —— View job

PR Review: Remove VR/MR switching methods

Read changed files to understand the scope of removal
Verify NetSyncManager.cs changes are complete
Check README.md documentation updates
Search for remaining references to removed methods
Review unity scene changes
Provide comprehensive review feedback

Review Summary

This PR successfully removes the SwitchToVR and SwitchToMR methods from the NetSyncManager API. The changes are clean and complete. Approved with minor observations below.

✅ What's Good

Complete removal: All related code removed cleanly:
- Public API methods (SwitchToVR, SwitchToMR) - NetSyncManager.cs:72-105
- Internal implementations (SwitchToVR_Internal, SwitchToMR_Internal) - NetSyncManager.cs:107-124
- RPC handlers for network synchronization - NetSyncManager.cs:613-633
- Sample script demonstrating the API (SwitchVRMR.cs)
- GameObject using the sample script in Demo-01 scene
Documentation updated: README.md properly cleaned up, replacing the "Others" section with a placeholder message instead of leaving broken examples
No breaking changes to remaining code: The PassthroughMode property correctly remains untouched (NetSyncManager.cs:70-71)
Remaining references are correct: Found references to StylyXrRig.SwitchToVR/MR() in Assets/Samples_Dev/AvatarAdjust/Debug.cs:25,29 are to a different API surface (direct XR Rig calls), which is expected per the PR description

📝 Observations

RPC switch statement now empty: After removing the VR/MR cases, the OnRPCReceivedHandler_SystemRPC method at NetSyncManager.cs:608-617 now has an empty switch statement with only a default case. This is fine functionally, but indicates the system RPC infrastructure is preserved for potential future use.
Scene file changes: The Demo-01.unity changes show clean removal of the GameObject with proper SceneRoots list update (removed reference to 1414538198)
Field remains: The passthroughMode field (NetSyncManager.cs:71) is retained but appears to no longer be modified since the SwitchToVR_Internal and SwitchToMR_Internal methods that set it are gone. This field may now be dead code unless there's another path that sets it not visible in this PR.

🔍 Minor Concern

Potential dead code: The passthroughMode private field (NetSyncManager.cs:71) was previously set by the removed SwitchToVR_Internal/SwitchToMR_Internal methods. With those methods gone, this field may never be updated. The public PassthroughMode property would always return the default value (false).

If this field/property is no longer useful, consider removing it in a follow-up PR. If there's another mechanism that sets passthroughMode that I'm not seeing, please disregard this observation.

Verdict

✅ LGTM - The PR successfully accomplishes its goal of removing the VR/MR switching methods from NetSyncManager. The changes are clean, complete, and properly documented. The minor observation about passthroughMode is non-blocking and can be addressed separately if needed.

from2001 · 2026-01-08T01:08:55Z

@copilot Remove PassthroughMode and other pass-through related code.

PassthroughMode is located at NetSyncManager.cs

Co-authored-by: from2001 <387880+from2001@users.noreply.github.com>

Copilot · 2026-01-08T01:11:35Z

@copilot Remove PassthroughMode and other pass-through related code.

PassthroughMode is located at NetSyncManager.cs
...

Removed PassthroughMode property and passthroughMode field from NetSyncManager.cs in commit f564a03.

from2001 · 2026-01-08T01:17:40Z

@copilot Update README.md

Co-authored-by: from2001 <387880+from2001@users.noreply.github.com>

Copilot · 2026-01-08T01:20:55Z

@copilot Update README.md

Updated README.md to remove the empty "Others" section in commit aabbd93.

from2001 · 2026-01-18T14:23:46Z

@gemini-cli /review

github-actions · 2026-01-18T14:23:54Z

🤖 Hi @from2001, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

github-actions

📋 Review Summary

This pull request effectively removes the deprecated VR/MR switching functionality and associated passthrough code from the NetSyncManager. The changes are comprehensive, covering the core logic, sample scripts, scene objects, and documentation.

🔍 General Feedback

The removal of the feature is clean and complete. All related files and code blocks have been appropriately deleted.
The corresponding documentation in README.md has also been updated, which is great for keeping the documentation in sync with the codebase.
The removal of the sample script and the object from the demo scene ensures that there are no broken references.

Overall, this is a solid refactoring effort that improves the maintainability of the codebase by removing unused features.

from2001 · 2026-01-18T14:25:37Z

@claude Resolve conflicts to develop branch.

claude · 2026-01-18T14:25:48Z

Claude finished @from2001's task in 3m 8s —— View job

Resolving merge conflicts with develop branch

Check current branch status
Fetch latest develop branch
Identify merge conflicts
Merge develop into current branch ← Requires permission
Resolve any conflicts that arise
Verify resolution maintains PR intent
Commit and push changes

Analysis Complete

I've analyzed the branches and identified the merge requirements. The git merge origin/develop command requires your approval to proceed.

Files that will be affected:

README.md - Version changes (0.7.1 → 0.7.3) and installation command updates from develop
NetSyncManager.cs - This PR's deletions will be preserved
Demo-01.unity - GameObject removal will be preserved
New files from develop - Workflow files and documentation will be added

The merge should be straightforward with minimal conflicts. Once I have permission to run git merge origin/develop, I'll complete the resolution and push the updated branch.

Waiting for approval to proceed with merge operation.

from2001 · 2026-01-18T14:30:25Z

@claude Remove the change of README.md from this PR.

claude · 2026-01-18T14:30:40Z

Claude finished @from2001's task in 2m 48s —— View job

Removing README.md changes from PR

Check current branch status and commit history
Restore README.md to develop branch state
Commit and push the changes
Verify the changes are correct

Summary

Successfully removed README.md changes from this PR. The README.md file has been restored to its original state (from commit 8d10b80), which includes:

The "Others" section with SwitchToVR/SwitchToMR documentation
All original formatting and content

Changes made:

Created commit 34417dd that restores README.md
The PR now only contains the NetSyncManager.cs, Demo-01.unity, and deleted sample file changes
README.md documentation is no longer modified by this PR

The branch has been updated and pushed to remote.

| Branch

Co-authored-by: Masahiro Yamaguchi <from2001@users.noreply.github.com>

from2001 · 2026-01-19T05:15:47Z

@gemini-cli /review

github-actions · 2026-01-19T05:15:58Z

🤖 Hi @from2001, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

github-actions

📋 Review Summary

This Pull Request successfully removes the deprecated VR/MR switching methods and related passthrough code, improving the codebase's clarity and maintainability. The changes are well-implemented and align with the stated objective.

🔍 General Feedback

The removal of unused code and sample files is well-executed.
The documentation update in README.md is thorough, though minor formatting consistency improvements for markdown are noted in inline comments.

github-actions · 2026-01-19T05:17:05Z

README.md

@@ -24,7 +24,7 @@ STYLY NetSync includes an easy-to-integrate Unity package and a lightweight Pyth

 ### Main features
 - Avatar Transform Synchronization


🟢 Consider using consistent formatting for lists in Markdown. For example, ensuring that there is no trailing space at the end of a line if it's not intended to be a line break. This improves readability and consistency. Also, ensure consistent use of backticks for code/variable names like _localAvatarPrefab instead of single quotes.

github-actions · 2026-01-19T05:17:07Z

README.md

@@ -38,8 +38,8 @@ Some features are provided via dependent package STYLY XR Rig.

 ### Prerequisites



🟢 Consistent usage of backticks for code snippets and variable names (e.g., uv/uvx, OpenUPM) improves readability in markdown documentation.

github-actions · 2026-01-19T05:17:08Z

README.md

@@ -117,9 +117,9 @@ The uvx command automatically downloads the package, creates an isolated virtual
 - _clientNo - Shows the numeric client number assigned by the server.
 - _serverAddress - Server IP or hostname; leave empty to auto-discover on the local network.
 - _roomId - Identifier of the current room to join.


🟢 Consistent use of backticks for code/variable names (e.g., _localAvatarPrefab, _remoteAvatarPrefab, _humanPresencePrefab) is good practice for markdown files. This improves the clarity and readability of the documentation.

github-actions · 2026-01-19T05:17:08Z

README.md

@@ -210,9 +210,9 @@ NetSyncManager.Instance.SwitchToMR(transitionDuration, syncOverNetwork);


 ## Transport layer


🟢 Ensure consistent spacing for list items. The extra spaces after the colon have been removed, which is good for readability.

Initial plan

2355548

Copilot AI assigned Copilot and from2001 Jan 8, 2026

Copilot started work on behalf of from2001 January 8, 2026 00:54 View session

Copilot AI and others added 2 commits January 8, 2026 00:57

Remove SwitchToVR and SwitchToMR methods from NetSync

5c3e067

Co-authored-by: from2001 <387880+from2001@users.noreply.github.com>

Remove SwitchVRMR GameObject from Demo-01 scene

5924760

Co-authored-by: from2001 <387880+from2001@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Remove switching VR/MR methods from NetSync~~ Remove VR/MR switching methods from NetSyncManager Jan 8, 2026

Copilot AI requested a review from from2001 January 8, 2026 01:02

Copilot finished work on behalf of from2001 January 8, 2026 01:03

Copilot started work on behalf of from2001 January 8, 2026 01:09 View session

Remove PassthroughMode property and related code

f564a03

Co-authored-by: from2001 <387880+from2001@users.noreply.github.com>

Copilot AI changed the title ~~Remove VR/MR switching methods from NetSyncManager~~ Remove VR/MR switching methods and passthrough code from NetSyncManager Jan 8, 2026

Copilot finished work on behalf of from2001 January 8, 2026 01:12

from2001 changed the title ~~Remove VR/MR switching methods and passthrough code from NetSyncManager~~ [Breaking change] Remove VR/MR switching methods and passthrough code from NetSyncManager Jan 8, 2026

Copilot started work on behalf of from2001 January 8, 2026 01:18 View session

Remove empty Others section from README.md

aabbd93

Co-authored-by: from2001 <387880+from2001@users.noreply.github.com>

Copilot finished work on behalf of from2001 January 8, 2026 01:21

github-actions bot reviewed Jan 18, 2026

View reviewed changes

Restore README.md to state before PR changes

34417dd

Co-authored-by: Masahiro Yamaguchi <from2001@users.noreply.github.com>

from2001 marked this pull request as ready for review January 19, 2026 05:15

github-actions bot reviewed Jan 19, 2026

View reviewed changes

from2001 merged commit b48e0cf into develop Jan 19, 2026

from2001 deleted the copilot/remove-vr-mr-switch-functions branch January 22, 2026 13:59

		@@ -24,7 +24,7 @@ STYLY NetSync includes an easy-to-integrate Unity package and a lightweight Pyth

		### Main features
		- Avatar Transform Synchronization

		@@ -38,8 +38,8 @@ Some features are provided via dependent package STYLY XR Rig.

		### Prerequisites

		@@ -210,9 +210,9 @@ NetSyncManager.Instance.SwitchToMR(transitionDuration, syncOverNetwork);


		## Transport layer

Conversation

Copilot AI commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Comments on the Issue (you are @copilot in this section)

Uh oh!

from2001 commented Jan 8, 2026

Uh oh!

claude bot commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review: Remove VR/MR switching methods

Review Summary

✅ What's Good

📝 Observations

🔍 Minor Concern

Verdict

Uh oh!

from2001 commented Jan 8, 2026

Uh oh!

Copilot AI commented Jan 8, 2026

Uh oh!

from2001 commented Jan 8, 2026

Uh oh!

Copilot AI commented Jan 8, 2026

Uh oh!

from2001 commented Jan 18, 2026

Uh oh!

github-actions bot commented Jan 18, 2026

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

📋 Review Summary

🔍 General Feedback

Uh oh!

from2001 commented Jan 18, 2026

Uh oh!

claude bot commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Resolving merge conflicts with develop branch

Analysis Complete

Uh oh!

from2001 commented Jan 18, 2026

Uh oh!

claude bot commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Removing README.md changes from PR

Summary

Uh oh!

from2001 commented Jan 19, 2026

Uh oh!

github-actions bot commented Jan 19, 2026

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

📋 Review Summary

🔍 General Feedback

Uh oh!

github-actions bot Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Jan 8, 2026 •

edited

Loading

claude bot commented Jan 8, 2026 •

edited

Loading

claude bot commented Jan 18, 2026 •

edited

Loading

claude bot commented Jan 18, 2026 •

edited

Loading