Fix at-rule-property-required-list message to use "descriptor" for accuracy (#8186)

ybiquitous · web-flow · commit 74f3c080f203 · 2024-12-13T09:25:05.000+09:00
Follow-up PR #8185 See also <#8148 (comment)> Note that it doesn't rename local variables to minimize code diffs and keep git-blame easy.
diff --git a/.changeset/blue-carrots-share.md b/.changeset/blue-carrots-share.md
@@ -0,0 +1,5 @@
+---
+"stylelint": patch
+---
+
+Fixed: `at-rule-property-required-list` message to use "descriptor" for accuracy
diff --git a/lib/rules/at-rule-property-required-list/index.cjs b/lib/rules/at-rule-property-required-list/index.cjs
@@ -10,10 +10,12 @@ const ruleMessages = require('../../utils/ruleMessages.cjs');
 const validateObjectWithArrayProps = require('../../utils/validateObjectWithArrayProps.cjs');
 const validateOptions = require('../../utils/validateOptions.cjs');
 
+// NOTE: We should have named this rule as `at-rule-descriptor-required-list` instead.
+// See https://github.com/stylelint/stylelint/pull/8185
 const ruleName = 'at-rule-property-required-list';
 
 const messages = ruleMessages(ruleName, {
-	expected: (atRule, property) => `Expected property "${property}" for at-rule "${atRule}"`,
+	expected: (atRule, descriptor) => `Expected descriptor "${descriptor}" for at-rule "${atRule}"`,
 });
 
 const meta = {
diff --git a/lib/rules/at-rule-property-required-list/index.mjs b/lib/rules/at-rule-property-required-list/index.mjs
@@ -6,10 +6,12 @@ import ruleMessages from '../../utils/ruleMessages.mjs';
 import validateObjectWithArrayProps from '../../utils/validateObjectWithArrayProps.mjs';
 import validateOptions from '../../utils/validateOptions.mjs';
 
+// NOTE: We should have named this rule as `at-rule-descriptor-required-list` instead.
+// See https://github.com/stylelint/stylelint/pull/8185
 const ruleName = 'at-rule-property-required-list';
 
 const messages = ruleMessages(ruleName, {
-	expected: (atRule, property) => `Expected property "${property}" for at-rule "${atRule}"`,
+	expected: (atRule, descriptor) => `Expected descriptor "${descriptor}" for at-rule "${atRule}"`,
 });
 
 const meta = {

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"stylelint": patch
 +---
++
 +Fixed: `at-rule-property-required-list` message to use "descriptor" for accuracy