feat: Add support for generic records in createUseVariable
#43
Conversation
🦋 Changeset detectedLatest commit: e4830d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the type system for createUseVariable by introducing a generic PropertyType parameter, allowing for more flexible and type-safe handling of token values while maintaining backward compatibility.
- Adds
PropertyTypegeneric parameter tocreateUseVariablefor improved type constraints - Relaxes
ExportKeysutility type constraint fromTokenValuetounknownfor better flexibility - Updates CLI version from 1.0.2 to 1.0.4
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tooling/cli/src/package.ts | Bumps CLI version to 1.0.4 to match package.json |
| theme/src/utils/createUseVariable.ts | Introduces PropertyType generic parameter for enhanced type safety and applies it consistently to function signatures |
| theme/src/types.ts | Relaxes ExportKeys constraint to unknown for greater flexibility as a utility type, removes unused TokenValue import |
| .changeset/early-tires-change.md | Documents the feature addition with appropriate patch version bumps |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This pull request adds support for generic record types in the
createUseVariableutility, making it more flexible and allowing usage with arbitrary value types instead of being restricted toTokenValue. The changes also update type definitions and the CLI package version accordingly.Generic record support and type improvements
ExportKeystype intheme/src/types.tsto allowRecord<string, unknown>instead of requiringTokenValue, enabling broader use cases for exported variable keys.createUseVariablefunction intheme/src/utils/createUseVariable.tsto accept a genericPropertyType, allowing defaults and transformations to work with any value type, not justTokenValue. [1] [2]Package version and metadata
1.0.2to1.0.4intooling/cli/src/package.tsto reflect the new feature.