Conversation
7dafc4e to
71fc095
Compare
kyranjamie
reviewed
Jun 2, 2022
71fc095 to
d22598b
Compare
Contributor
Author
|
cc @kyranjamie |
Contributor
|
So the gist here is just creating an alternate method that synchronously loads the connect dialog? Code looks good but, I'm not so familiar with stencil so have nothing specific to suggest. |
Contributor
Author
Yep, although upon re-checking the latest release literally just added a fix for this, days ago. It's marked as experimental, but I'll test in a new PR. UPDATE: the other fix doesn't seem to work in the case. so i'm going to stick with the |
d22598b to
350aa11
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dist-custom-elementsdistribution ofconnect-ui, since rollup-based projects don't handle dynamic loaded stencil wellshowConnectStaticmethod (just a copy ofshowConnectwithout dynamic loading)using
*Staticwould always bundle the connect-ui (ideally only shown when somebody has an incompatible browser, or is missing the wallet extension) into a project. however, developers could adjust their configs (e.g. rollup >manualChunks) to achieve similar dynamic loading/chunking, but handled by the last bundler in the build step (rather than stencil before distribution, which is optimized for webpack)