Refuse to override builtin file type

bajtos · bajtos · commit 2c4cc6eae4db · 2016-10-31T10:21:33.000-07:00
Arguments of { type: 'file' } are handled specially by strong-remoting
and don't go through the usual TypeConverter path.

This causes problems in LoopBack applications with a model called
"File", which registers a type converter for "file" (the name is case
insensitive).

In this commit, we are modifying TypeRegistry to throw an error when
the caller attempts to override the built-in "file" type.
diff --git a/lib/type-registry.js b/lib/type-registry.js
@@ -32,6 +32,10 @@ TypeRegistry.prototype.registerType = function(typeName, converter) {
 
   typeName = typeName.toLowerCase();
 
+  if (typeName === 'file') {
+    throw new Error(g.f('Cannot override built-in "{{file}}" type.'));
+  }
+
   if (typeName in this._types) {
     if (this._options.warnWhenOverridingType !== false)
       g.warn('Warning: overriding remoting type %s', typeName);
diff --git a/test/type-registry.test.js b/test/type-registry.test.js
@@ -0,0 +1,19 @@
+var expect = require('chai').expect;
+var TypeRegistry = require('../lib/type-registry');
+
+describe('TypeRegistry', function() {
+  var registry;
+  beforeEach(function() {
+    registry = new TypeRegistry();
+  });
+
+  it('refuses to override built-in file type', function() {
+    expect(function() {
+      registry.registerType('File', {
+        fromTypedValue: function() {},
+        fromSloppyValue: function() {},
+        validate: function() {},
+      });
+    }).to.throw(/file/);
+  });
+});
