Add support for ES6 style async boot scripts#253
Merged
bajtos merged 1 commit intostrongloop:masterfrom Dec 11, 2017
lehni:feature/async-boot-scripts-master
Merged
Add support for ES6 style async boot scripts#253bajtos merged 1 commit intostrongloop:masterfrom lehni:feature/async-boot-scripts-master
bajtos merged 1 commit intostrongloop:masterfrom
lehni:feature/async-boot-scripts-master
Conversation
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
Member
|
@raymondfeng @davidcheung please review. You may want to consider my comments in #252 too. |
Member
|
@slnode ok to test |
2 tasks
Member
Contributor
Author
|
@bajtos I am back from my holiday, will look into these pending things now! |
Member
|
@lehni sounds good, welcome back! :) |
Contributor
Author
bajtos
approved these changes
Aug 18, 2017
Member
bajtos
left a comment
There was a problem hiding this comment.
LGTM. Let's give some time for @raymondfeng to review too.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows boot scripts to be defined in the ES6 async fashion, without the need for passing callbacks:
Related issues
Checklist
guide