Replace other require cgi with require cgi/escape#1841
Merged
xavdid-stripe merged 1 commit intostripe:masterfrom Mar 27, 2026
Merged
Replace other require cgi with require cgi/escape#1841xavdid-stripe merged 1 commit intostripe:masterfrom
xavdid-stripe merged 1 commit intostripe:masterfrom
Conversation
I missed this case in f69d848. This require is only needed if you support requiring stripe/util without requiring stripe. If you don't intend to support that, you can remove it completely.
xavdid-stripe
approved these changes
Mar 27, 2026
Contributor
xavdid-stripe
left a comment
There was a problem hiding this comment.
nice! I'm not sure what people are requireing out there (whether we intend it or not), so we'll play it safe.
Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I missed this case in f69d848.
This require is only needed if you support requiring stripe/util without requiring stripe. If you don't intend to support that, you can remove it completely.