Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Ruby's
net/httpcan raiseNet::HTTPFatalErrorfor 5xx responses (link) before stripe-ruby converts the response into aStripe::StripeError. Because our retry logic only retried known network exceptions andStripe::StripeErrorinstances, these transient 5xx failures were not retried.This change makes retry behavior consistent for that code path so temporary 5xx failures surfaced as
Net::HTTPFatalErrorare retried like other transient server-side failures.What?
Net::HTTPFatalErroras retryable inAPIRequestor.should_retry?Net::HTTPFatalErrorthroughNETWORK_ERROR_MESSAGES_MAPso exhausted retries raiseStripe::APIConnectionErrorChangelog
Net::HTTPFatalErrorerrors were being thrown and not retried (unlike other 5xx responses from the Stripe API)