Skip to content

StripeCryptoOnramp: Fix RequiresNextAction Fail/Cancel Bugs#13074

Merged
Twigz merged 7 commits into
masterfrom
twigz/fix-3ds-cancellation-checkout-bug
May 26, 2026
Merged

StripeCryptoOnramp: Fix RequiresNextAction Fail/Cancel Bugs#13074
Twigz merged 7 commits into
masterfrom
twigz/fix-3ds-cancellation-checkout-bug

Conversation

@Twigz

@Twigz Twigz commented May 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  1. Fixes an issue when a RequiresNextAction prompt would fail, the checkout process would hang due to being considered "inProgress" still, so later checkout attempts would no-op. Cancel/fail now goes through the interactor and terminates in a Completed state.
  2. Fixes an issue with cancellation where the presenter would continuously launch the "Next Action" every time it saw a RequiresNextAction, regardless of it had already launched it. This was fixed by creating a de-duplication guard on presentation.

Added a number of tests to attempt to ensure this behavior continues properly.

Motivation

Fixing issues with the SDK from bug reports around 3DS2 issues.

Testing

  • Added tests
  • Modified tests
  • Manually verified

@Twigz Twigz requested a review from jeanregisser May 11, 2026 20:37
@Twigz Twigz requested review from a team as code owners May 11, 2026 20:37
jeanregisser
jeanregisser previously approved these changes May 21, 2026

@jeanregisser jeanregisser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🚀

Could we also update the CHANGELOG for this change?

@Twigz Twigz merged commit 87772ab into master May 26, 2026
64 checks passed
@Twigz Twigz deleted the twigz/fix-3ds-cancellation-checkout-bug branch May 26, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants