Fix CustomerSheetLoader to return filtered payment methods.#13020
Merged
jaynewstrom-stripe merged 2 commits intoMay 5, 2026
Conversation
Merged
3 tasks
amk-stripe
approved these changes
May 5, 2026
Collaborator
|
Yikes, thanks for finding and fixing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a bug in
CustomerSheetLoaderwhere unfiltered payment methods were being returned instead of the filtered valid ones.Originally introduced here: https://github.com/stripe/stripe-android/pull/12752/changes#diff-7e1c4fa61c4e70690ef87fb3dfdb252c9c074d31d29d1040f31030a10a864489R221
Motivation
The
CustomerSheetLoaderwas incorrectly returningsupportedPaymentMethodsinstead ofvalidSupportedPaymentMethods, which meant that unsupported payment method types (like SEPA debit and Klarna) were not being filtered out properly. This could cause issues when CustomerSheet tries to display payment methods that aren't actually supported.Testing
Changelog
[Fixed] CustomerSheet now correctly filters out unsupported payment method types.