Skip to content

[Identity] Manual Capture#12987

Merged
Pearapps merged 17 commits into
masterfrom
kpa/manual-capture
Jun 4, 2026
Merged

[Identity] Manual Capture#12987
Pearapps merged 17 commits into
masterfrom
kpa/manual-capture

Conversation

@Pearapps

@Pearapps Pearapps commented Apr 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

• adds a manual capture mode for identity documents directly in the existing capture screen with a Live / Manual switch
• keeps the same camera/viewfinder UI in manual mode, disables live scanning feedback + auto-capture, and lets the user explicitly tap Take Photo
• hides the switch on the timeout/error screen and updates manual capture copy from Scanned to Image taken
• only allows manual capture when live verification is not required

You can see the switch and new UI here:

Screenshot_20260507-104018

@github-actions

github-actions Bot commented Apr 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │   4.6 MiB │   4.6 MiB │     +5 B │   9.7 MiB │   9.7 MiB │      0 B 
     arsc │   3.8 MiB │   3.8 MiB │ +1.5 KiB │   3.8 MiB │   3.8 MiB │ +1.5 KiB 
 manifest │   5.8 KiB │   5.8 KiB │      0 B │  30.8 KiB │  30.8 KiB │      0 B 
      res │     1 MiB │     1 MiB │     -2 B │   1.7 MiB │   1.7 MiB │      0 B 
   native │   2.7 MiB │   2.7 MiB │      0 B │   2.7 MiB │   2.7 MiB │      0 B 
    asset │    25 KiB │    25 KiB │     -1 B │  45.8 KiB │  45.8 KiB │     -1 B 
    other │ 245.4 KiB │ 245.4 KiB │    +14 B │ 505.1 KiB │ 505.1 KiB │      0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  12.3 MiB │  12.3 MiB │ +1.5 KiB │  18.4 MiB │  18.4 MiB │ +1.5 KiB 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 45300 │ 45300 │ 0 (+0 -0) 
   types │ 14274 │ 14274 │ 0 (+0 -0) 
 classes │ 11594 │ 11594 │ 0 (+0 -0) 
 methods │ 63394 │ 63394 │ 0 (+0 -0) 
  fields │ 41170 │ 41170 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff       
─────────┼──────┼──────┼────────────
 configs │  319 │  319 │  0         
 entries │ 7477 │ 7479 │ +2 (+2 -0)
APK 
     compressed      │     uncompressed     │                               
──────────┬──────────┼───────────┬──────────┤                               
 size     │ diff     │ size      │ diff     │ path                          
──────────┼──────────┼───────────┼──────────┼───────────────────────────────
  3.8 MiB │ +1.5 KiB │   3.8 MiB │ +1.5 KiB │ ∆ resources.arsc              
 58.9 KiB │    +13 B │ 130.6 KiB │      0 B │ ∆ META-INF/CERT.SF            
  4.6 MiB │     +5 B │   9.7 MiB │      0 B │ ∆ classes.dex                 
  1.1 KiB │     -2 B │   3.3 KiB │      0 B │ ∆ res/nn.xml                  
  8.9 KiB │     -1 B │   8.8 KiB │     -1 B │ ∆ assets/dexopt/baseline.prof 
  1.2 KiB │     +1 B │   1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA           
──────────┼──────────┼───────────┼──────────┼───────────────────────────────
  8.4 MiB │ +1.5 KiB │  13.6 MiB │ +1.5 KiB │ (total)
ARSC 
ENTRIES:

   old  │ new  │ diff       
  ──────┼──────┼────────────
   7477 │ 7479 │ +2 (+2 -0) 
  + string/stripe_paymentsheet_manage_payment_method
  + string/stripe_paymentsheet_unknown_details_cannot_be_changed

@Pearapps Pearapps marked this pull request as ready for review May 7, 2026 15:27
@Pearapps Pearapps requested review from a team as code owners May 7, 2026 15:27
@Pearapps Pearapps requested a review from aywang-stripe May 7, 2026 15:27
@Pearapps Pearapps requested a review from cjmisenas-stripe May 7, 2026 18:41
mnn-stripe
mnn-stripe requested changes May 19, 2026
View reviewed changes
Comment thread identity/res/values-en-rGB/strings.xml Outdated
@Pearapps Pearapps requested a review from mnn-stripe May 26, 2026 20:16
mnn-stripe
mnn-stripe previously approved these changes May 27, 2026
View reviewed changes

@mnn-stripe mnn-stripe left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cjmisenas-stripe cjmisenas-stripe requested a review from a team as a code owner June 4, 2026 17:36
@Pearapps Pearapps merged commit 5ea684c into master Jun 4, 2026
53 checks passed
@Pearapps Pearapps deleted the kpa/manual-capture branch June 4, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjmisenas-stripe cjmisenas-stripe cjmisenas-stripe approved these changes

@mnn-stripe mnn-stripe mnn-stripe left review comments

@aywang-stripe aywang-stripe Awaiting requested review from aywang-stripe aywang-stripe is a code owner automatically assigned from stripe/android-identity-reviewers

@toluo-stripe toluo-stripe Awaiting requested review from toluo-stripe toluo-stripe is a code owner automatically assigned from stripe/android-payments-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Pearapps @mnn-stripe @cjmisenas-stripe