Adding new embedded theming token types to Android SDK by mirandajiang-stripe · Pull Request #12695 · stripe/stripe-android

mirandajiang-stripe · 2026-03-17T22:24:28Z

r? @stripe/mx-mobile-reviewers
r? @stripe/android-sdk-reviewers

Summary

In this PR, the mappings of Android SDK names to the web ConnectJS names of the new theming tokens for embedded components were added. This change allows platforms to customize embedded components on Android as well, ensuring a consistent experience across mobile and web.

Additionally, a new testing interface for the theming tokens was added in connect-example. This allows for easier testing of the new tokens since users can granularly change the values. Previously, we could only see a difference in theme by changing a preset theme, which would make it difficult to see the effects the changes would have and catch any bugs with testing.

Some parameters were deprecated due to the addition of the new classes Form and Action. The deprecated parameters were moved out of the Colors class if it was a token that affected Form or Action components since it is better categorized there.

Motivation

Platforms requested more granular theming to ensure the embedded UI matches their native UI. New tokens that allow finer control over padding, font, and color for components have been implemented on ConnectJS behind the enable_new_embedded_theming_tokens flag. The last phase of implementation is to bring this to mobile SDKs.

For more context: Adding additional theming functionality for embedded components

Testing

Testing was done locally with the Android Simulator. A screen recording is provided below

Added tests
Modified tests
Manually verified

Screenshots

Screen.Recording.2026-03-30.at.9.39.26.AM.mov

Changelog

github-actions · 2026-03-17T22:30:30Z

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   2.2 MiB │   2.2 MiB │  0 B │   4.6 MiB │   4.6 MiB │  0 B 
     arsc │   1.2 MiB │   1.2 MiB │  0 B │   1.2 MiB │   1.2 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │   298 KiB │   298 KiB │  0 B │ 447.6 KiB │ 447.6 KiB │  0 B 
   native │  18.6 MiB │  18.6 MiB │  0 B │  18.6 MiB │  18.6 MiB │  0 B 
    asset │   7.9 KiB │   7.9 KiB │  0 B │   7.7 KiB │   7.7 KiB │  0 B 
    other │ 110.1 KiB │ 110.1 KiB │  0 B │ 235.1 KiB │ 235.1 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  22.4 MiB │  22.4 MiB │  0 B │    25 MiB │    25 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 22058 │ 22058 │ 0 (+0 -0) 
   types │  6589 │  6589 │ 0 (+0 -0) 
 classes │  5318 │  5318 │ 0 (+0 -0) 
 methods │ 32267 │ 32267 │ 0 (+0 -0) 
  fields │ 18595 │ 18595 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  158 │  158 │  0   
 entries │ 3979 │ 3979 │  0

APK

   compressed    │  uncompressed   │                     
──────────┬──────┼──────────┬──────┤                     
 size     │ diff │ size     │ diff │ path                
──────────┼──────┼──────────┼──────┼─────────────────────
 29.3 KiB │ +3 B │   65 KiB │  0 B │ ∆ META-INF/CERT.SF  
  1.2 KiB │ -3 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA 
──────────┼──────┼──────────┼──────┼─────────────────────
 30.5 KiB │  0 B │ 66.2 KiB │  0 B │ (total)

jaynewstrom-stripe

You can fix the build errors by running ./gradlew detektFormat --no-configuration-cache locally.

You can make sure there won't be any build/CI issues by running CI=true ./gradlew :connect:compileDebugKotlin locally.

jaynewstrom-stripe · 2026-03-18T12:48:09Z

+@Poko
+@PreviewConnectSDK
+class Action private constructor(
+    @ColorInt internal val colorText: Int? = null,


Is there a need for the default here?

Suggested change

@ColorInt internal val colorText: Int? = null,

@ColorInt internal val colorText: Int?,

This same comment applies to nearly all the new things. I think you can get rid of them all.

I was following the same pattern as the existing classes. They all have <type>? = null. Should I be changing it for the new classes? Or follow that same pattern?

Since these all should have builders, there shouldn't be a need for defaults (and it just bloats the code, as the kotlin compiler generates additional code for this pattern).

mirandajiang-stripe · 2026-03-30T16:55:09Z

The bitrise check is failing and I'm not too sure why. It would be great if I could have some help figuring out what the issue is!

jaynewstrom-stripe · 2026-04-01T13:02:48Z

+@Poko
+@PreviewConnectSDK
+class Action private constructor(
+    @ColorInt internal val colorText: Int? = null,


Since these all should have builders, there shouldn't be a need for defaults (and it just bloats the code, as the kotlin compiler generates additional code for this pattern).

gimenete-stripe

Looking good! I left a few comments.

Would be also good to add some tests.

jaynewstrom-stripe · 2026-04-02T12:20:46Z

+public final class com/stripe/android/connect/appearance/BadgeDefaults : android/os/Parcelable {
+	public static final field $stable I
+	public static final field CREATOR Landroid/os/Parcelable$Creator;
+	public fun <init> (Ljava/lang/Float;Ljava/lang/Float;Lcom/stripe/android/connect/appearance/Typography$Style;)V


Constructor should be private/internal.

I made it private now but ./gradlew apiDump still generates it with public final class which is the pattern that all the classes follow in this file.

jaynewstrom-stripe · 2026-04-02T12:21:11Z

+public final class com/stripe/android/connect/appearance/ButtonDefaults : android/os/Parcelable {
+	public static final field $stable I
+	public static final field CREATOR Landroid/os/Parcelable$Creator;
+	public fun <init> (Ljava/lang/Float;Ljava/lang/Float;Lcom/stripe/android/connect/appearance/Typography$Style;)V


Constructor should be private/internal.

Same thing with my comment from above

mirandajiang-stripe · 2026-04-02T20:50:09Z

Looking good! I left a few comments.

Would be also good to add some tests.

Thanks for the feedback! I added some tests to check that the new tokens are mapping properly and serializes to the correct values. I also added tests to check the deprecated parameters don't cause a breaking change. It still works if the parameters in Form and Action aren't defined, but when they are defined, then the value within the Form and Action classes are used.

gimenete-stripe

Approving since my feedback has been addressed! Great work!

Not sure about the constructors being private/internal. I'm not a Kotlin expert.

… buttons

mirandajiang-stripe · 2026-04-02T22:49:07Z

Approving since my feedback has been addressed! Great work!

Not sure about the constructors being private/internal. I'm not a Kotlin expert.

Thank you! I had to make some new changes because the bitrise check was failing but I just had to rebase and it's passing now. Could I get it approved again?

gimenete-stripe

👍

samer-stripe

LGTM!

jaynewstrom-stripe reviewed Mar 18, 2026

View reviewed changes

mirandajiang-stripe force-pushed the new-tokens-android branch from ad30305 to 2007d1e Compare March 27, 2026 16:36

mirandajiang-stripe marked this pull request as ready for review March 30, 2026 16:47

mirandajiang-stripe requested review from a team as code owners March 30, 2026 16:47

jaynewstrom-stripe reviewed Apr 1, 2026

View reviewed changes

samer-stripe reviewed Apr 1, 2026

View reviewed changes

Comment thread connect/src/main/java/com/stripe/android/connect/appearance/BadgeDefaults.kt Outdated

samer-stripe reviewed Apr 1, 2026

View reviewed changes

Comment thread connect/src/main/java/com/stripe/android/connect/appearance/ButtonDefaults.kt Outdated

gimenete-stripe reviewed Apr 2, 2026

View reviewed changes

jaynewstrom-stripe reviewed Apr 2, 2026

View reviewed changes

Comment thread connect/api/connect.api

gimenete-stripe previously approved these changes Apr 2, 2026

View reviewed changes

mirandajiang-stripe dismissed gimenete-stripe’s stale review via 0a11772 April 2, 2026 21:32

mirandajiang-stripe added 12 commits April 2, 2026 15:08

adding new tokens to Android SDK

d7a99ea

rebasing

ef85d1b

adding in new structure of padding and label typography for badge and…

431015e

… buttons

adding ability for custome theme

205348b

changes for set themes to follow new structure

6db32d9

some fixes

e8fee4c

adding changes

ff5baa8

adding file

74fa302

rebasing

06c963c

more fields in custom theme overrides

80534db

ran apiDump

d170487

function name updates

1794fde

mirandajiang-stripe added 8 commits April 2, 2026 15:08

more name changes

9e20131

removing new tokens theme from testing

4384b59

adding builders

c7f45cf

removing default values from form

2b2d83e

clean up

3b53b06

adding in private constructors and tests

e4d2da3

fixes for bitrise

53cfc92

preventing breaking changes for actionText

139a5cf

mirandajiang-stripe force-pushed the new-tokens-android branch from 0a11772 to 139a5cf Compare April 2, 2026 22:09

mirandajiang-stripe requested review from gimenete-stripe, jaynewstrom-stripe and samer-stripe April 2, 2026 22:49

gimenete-stripe approved these changes Apr 3, 2026

View reviewed changes

mirandajiang-stripe mentioned this pull request Apr 3, 2026

Update CHANGELOG.md #12839

Merged

samer-stripe approved these changes Apr 6, 2026

View reviewed changes

mirandajiang-stripe merged commit a30e29c into master Apr 6, 2026
19 checks passed

mirandajiang-stripe deleted the new-tokens-android branch April 6, 2026 16:38

	@ColorInt internal val colorText: Int? = null,
	@ColorInt internal val colorText: Int?,

Conversation

mirandajiang-stripe commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Motivation

Testing

Screenshots

Changelog

Uh oh!

github-actions Bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jaynewstrom-stripe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mirandajiang-stripe commented Mar 30, 2026

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gimenete-stripe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mirandajiang-stripe commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gimenete-stripe left a comment

Choose a reason for hiding this comment

Uh oh!

mirandajiang-stripe commented Apr 2, 2026

Uh oh!

gimenete-stripe left a comment

Choose a reason for hiding this comment

Uh oh!

samer-stripe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mirandajiang-stripe commented Mar 17, 2026 •

edited

Loading

github-actions Bot commented Mar 17, 2026 •

edited

Loading

mirandajiang-stripe commented Apr 2, 2026 •

edited

Loading