Skip to content

Fix project dependency artifactId resolution in pom generation logic.#12596

Merged
jaynewstrom-stripe merged 1 commit intomasterfrom
jaynewstrom/improve-pom-dependency-handling
Mar 10, 2026
Merged

Fix project dependency artifactId resolution in pom generation logic.#12596
jaynewstrom-stripe merged 1 commit intomasterfrom
jaynewstrom/improve-pom-dependency-handling

Conversation

@jaynewstrom-stripe
Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe commented Mar 10, 2026 •
edited
Loading

Summary

Fixed the project dependency artifactId resolution in pom generation logic within deploy.gradle. Now, the artifactId is correctly used when generating the pom for project dependencies.

Motivation

Previously, project dependencies could resolve to the incorrect artifactId ("unspecified" or default project name) in generated pom files due to not handling the project artifactId property properly. This change ensures consistency in published artifacts and avoids potential downstream dependency resolution issues.

Testing

  • Added tests
  • Modified tests
  • Manually verified

Changelog

  • [Fixed] Correctly resolve project dependency artifactId when generating pom files to ensure accurate dependency metadata.

Fixes #12595

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2026

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   2.2 MiB │   2.2 MiB │  0 B │   4.6 MiB │   4.6 MiB │  0 B 
     arsc │   1.2 MiB │   1.2 MiB │  0 B │   1.2 MiB │   1.2 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │   298 KiB │   298 KiB │  0 B │ 447.6 KiB │ 447.6 KiB │  0 B 
   native │  18.6 MiB │  18.6 MiB │  0 B │  18.6 MiB │  18.6 MiB │  0 B 
    asset │   7.9 KiB │   7.9 KiB │  0 B │   7.6 KiB │   7.6 KiB │  0 B 
    other │ 110.3 KiB │ 110.3 KiB │  0 B │ 237.3 KiB │ 237.3 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  22.4 MiB │  22.4 MiB │  0 B │    25 MiB │    25 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 22028 │ 22028 │ 0 (+0 -0) 
   types │  6586 │  6586 │ 0 (+0 -0) 
 classes │  5315 │  5315 │ 0 (+0 -0) 
 methods │ 32247 │ 32247 │ 0 (+0 -0) 
  fields │ 18592 │ 18592 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  158 │  158 │  0   
 entries │ 3979 │ 3979 │  0
APK 
   compressed    │   uncompressed   │                                           
──────────┬──────┼───────────┬──────┤                                           
 size     │ diff │ size      │ diff │ path                                      
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
  1.2 KiB │ -3 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
    272 B │ +1 B │     120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
 29.3 KiB │ +1 B │    65 KiB │  0 B │ ∆ META-INF/CERT.SF                        
 25.8 KiB │ +1 B │  64.9 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 56.6 KiB │  0 B │ 131.2 KiB │  0 B │ (total)

@jaynewstrom-stripe jaynewstrom-stripe marked this pull request as ready for review March 10, 2026 17:26
@jaynewstrom-stripe jaynewstrom-stripe requested review from a team as code owners March 10, 2026 17:26
@jaynewstrom-stripe jaynewstrom-stripe enabled auto-merge (squash) March 10, 2026 17:26
@jaynewstrom-stripe jaynewstrom-stripe mentioned this pull request Mar 10, 2026
Closed
@jaynewstrom-stripe jaynewstrom-stripe merged commit 46338f9 into master Mar 10, 2026
19 checks passed
@jaynewstrom-stripe jaynewstrom-stripe deleted the jaynewstrom/improve-pom-dependency-handling branch March 10, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tjclawson-stripe tjclawson-stripe tjclawson-stripe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] [P1] SDK 23.0.0 is not resolving internal dependencies

2 participants

@jaynewstrom-stripe @tjclawson-stripe