Update compose and androidx dependencies - bump minSDK/compileSDK versions.#12419
Update compose and androidx dependencies - bump minSDK/compileSDK versions.#12419jaynewstrom-stripe merged 4 commits intomasterfrom
Conversation
|
Diffuse output: APKMANIFESTDEX |
2 builds increased size, 1 build decreased size
Stripe Identity Example 22.8.1-theme1 (20)
|
| Item | Install Size Change | Download Size Change |
|---|---|---|
| androidx.compose.material.ComposableSingletons$AppBarKt | ⬆️ 27.1 kB | ⬆️ 13.1 kB |
| kotlin.collections.CollectionsKt__IterablesKt | ⬇️ -24.7 kB | ⬇️ -11.9 kB |
| 🗑 androidx.compose.ui.focus.FocusInteropUtils | ⬇️ -21.4 kB | ⬇️ -10.3 kB |
| androidx.compose.ui.focus.FocusChangedModifierKt | ⬆️ 19.3 kB | ⬆️ 9.3 kB |
| androidx.compose.ui.input.key.KeyEvent_androidKt | ⬇️ -19.1 kB | ⬇️ -9.2 kB |
Financial Connections Example 22.8.1 (220801)
com.stripe.android.financialconnections.example
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 37.3 kB (0.35%)
Total download size change: ⬆️ 40.1 kB (0.85%)
Largest size changes
| Item | Install Size Change | Download Size Change |
|---|---|---|
| androidx.compose.ui.input.key.KeyEvent_androidKt | ⬇️ -44.8 kB | ⬇️ -21.1 kB |
| androidx.compose.material.ComposableSingletons$AppBarKt | ⬆️ 32.7 kB | ⬆️ 15.5 kB |
| 📝 kotlin.TuplesKt | ⬆️ 27.9 kB | ⬆️ 13.2 kB |
| kotlin.collections.SetsKt | ⬆️ 25.8 kB | ⬆️ 12.2 kB |
| 🗑 com.stripe.android.model.parsers.PaymentMethodJsonParser$USBankAc... | ⬇️ -23.4 kB | ⬇️ -11.1 kB |
PaymentSheet Example 22.8.1 (11)
com.stripe.android.paymentsheet.example
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 2.4 MB (-15.3%)
Total download size change: ⬇️ 831.3 kB (-12.18%)
Largest size changes
| Item | Install Size Change | Download Size Change |
|---|---|---|
| 🗑 layout-v22 | ⬇️ -19.6 kB | ⬇️ -19.6 kB |
| kotlin.math.MathKt | ⬆️ 41.8 kB | ⬆️ 19.6 kB |
| 🗑 com.google.android.libraries.places.internal.zzbew | ⬇️ -35.8 kB | ⬇️ -16.1 kB |
| com.google.gson.JsonElement | ⬆️ 32.5 kB | ⬆️ 15.2 kB |
| androidx.fragment.app.FragmentManagerImpl | ⬆️ 31.5 kB | ⬆️ 14.8 kB |
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
6c78ddb to
59d74e7
Compare
59d74e7 to
ddf4047
Compare
There was a problem hiding this comment.
I spent ~2 hours trying to fix this. This PR doesn't introduce this bug, it just demonstrates it in compose 1.10. I'll file a PQ ticket with the link team to address it.
Merchants would see this if they're using compose 1.10 regardless of what we do.
There was a problem hiding this comment.
I was able to get the sizing to be better with some manual scaling stuff, but the alignment was consistently a problem. So my hunch is there's some bug in compose somewhere.
I tried the latest alpha, but the bug still existed there too.
There was a problem hiding this comment.
There was a problem hiding this comment.



Summary
Updates a bunch of androidx and compose dependencies.